From: Thierry Reding <thierry.reding@gmail.com>
To: Vandana Kannan <vandana.kannan@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/4] drm/crtc: Add property for aspect ratio
Date: Thu, 5 Jun 2014 11:28:21 +0200 [thread overview]
Message-ID: <20140605092819.GB23099@ulmo> (raw)
In-Reply-To: <1401959408-11140-1-git-send-email-vandana.kannan@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]
On Thu, Jun 05, 2014 at 02:40:08PM +0530, Vandana Kannan wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
> /**
> + * drm_mode_create_aspect_ratio_property - create aspect ratio property
> + * @dev: DRM device
> + *
> + * Called by a driver the first time it's needed, must be attached to desired
> + * connectors.
> + */
> +int drm_mode_create_aspect_ratio_property(struct drm_device *dev)
> +{
> + if (dev->mode_config.aspect_ratio_property)
> + return 0;
> +
> + dev->mode_config.aspect_ratio_property =
> + drm_property_create_enum(dev, 0, "aspect ratio",
> + drm_aspect_ratio_enum_list,
> + ARRAY_SIZE(drm_aspect_ratio_enum_list));
> +
> + return 0;
Sorry for not noticing this before: what if drm_propert_create_enum()
fails? Should that return an error? This function will currently
silently ignore failure to create the property.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-06-05 9:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 11:20 [PATCH 1/3] drm/crtc: Add property for aspect ratio Vandana Kannan
2014-05-22 11:20 ` [PATCH 2/3] drm/edid: Check for user aspect ratio input Vandana Kannan
2014-05-22 11:42 ` Thierry Reding
2014-05-23 10:44 ` Vandana Kannan
2014-05-26 10:07 ` [PATCH v2 2/4] " Vandana Kannan
2014-06-05 6:33 ` Thierry Reding
2014-06-05 9:15 ` [PATCH v3 " Vandana Kannan
2014-06-05 9:25 ` Thierry Reding
2014-05-22 11:20 ` [PATCH 3/3] drm/i915: Add aspect ratio property for HDMI Vandana Kannan
2014-05-23 2:29 ` Vandana Kannan
2014-05-26 10:11 ` [PATCH v2 3/4] " Vandana Kannan
2014-06-11 5:36 ` [PATCH v3 " Vandana Kannan
2014-05-22 11:38 ` [PATCH 1/3] drm/crtc: Add property for aspect ratio Thierry Reding
2014-05-23 10:41 ` Vandana Kannan
2014-05-22 12:16 ` [Intel-gfx] " Daniel Vetter
2014-05-23 10:48 ` Vandana Kannan
2014-05-26 5:30 ` [Intel-gfx] " Vandana Kannan
2014-05-26 7:54 ` Daniel Vetter
2014-05-26 10:04 ` [PATCH v2 1/4] " Vandana Kannan
2014-06-05 6:40 ` Thierry Reding
2014-06-05 9:10 ` [PATCH v3 " Vandana Kannan
2014-06-05 9:28 ` Thierry Reding [this message]
2014-06-10 8:30 ` Vandana Kannan
2014-06-10 11:15 ` Thierry Reding
2014-06-11 5:16 ` [PATCH v4 " Vandana Kannan
2014-07-01 5:01 ` Vandana Kannan
2014-07-14 6:51 ` Thierry Reding
2014-07-15 6:48 ` [Intel-gfx] " Daniel Vetter
2014-07-15 15:23 ` Vandana Kannan
2014-07-09 21:16 ` [Intel-gfx] [PATCH 1/3] " Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605092819.GB23099@ulmo \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandana.kannan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox