From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] [I-G-T]Add rc6_residency_counter subtest Date: Thu, 5 Jun 2014 10:19:12 -0700 Message-ID: <20140605171912.GA7913@bwidawsk.net> References: <1401935262-23220-1-git-send-email-wendy.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 501AD6E99F for ; Thu, 5 Jun 2014 10:19:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1401935262-23220-1-git-send-email-wendy.wang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Wendy Wang Cc: intel-gfx@lists.freedesktop.org, "Liu, Lei A" , benjamin.widawsky@intel.com List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 05, 2014 at 10:27:42AM +0800, Wendy Wang wrote: > Move rc6_residency_check to subtest, add new rc6_residency_counter subtest > for pm_rc6_residency IGT case. > Looks good to me. You have some formatting issues: for loops don't use the right coding style useless comment to fopen bad sign-off in mail added unnecessary whitespace replace assert with open coded abort So I've merged it with all those warts (except I fixed the signed-off-by). Please keep these things in mind next patch, and feel free to submit patches to fix these issues as well. [snip] -- Ben Widawsky, Intel Open Source Technology Center