From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/vlv: drop punit freq staus read after setting idle Date: Fri, 6 Jun 2014 11:29:24 +0300 Message-ID: <20140606082924.GD27580@intel.com> References: <1402001374-2657-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 321016E2EE for ; Fri, 6 Jun 2014 01:29:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402001374-2657-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 05, 2014 at 01:49:34PM -0700, Jesse Barnes wrote: > This may take awhile (~10ms), and we don't need to make noise about it. > = > References: https://bugs.freedesktop.org/show_bug.cgi?id=3D75244 > Tested-by: huax.lu@intel.com > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_pm.c | 4 ---- > 1 file changed, 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index ee27d74..4eebfd8 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -3227,10 +3227,6 @@ static void vlv_set_rps_idle(struct drm_i915_priva= te *dev_priv) > vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, > dev_priv->rps.min_freq_softlimit); > = > - if (wait_for(((vlv_punit_read(dev_priv, PUNIT_REG_GPU_FREQ_STS)) > - & GENFREQSTATUS) =3D=3D 0, 5)) > - DRM_ERROR("timed out waiting for Punit\n"); > - As I recall the entire point of this was to make sure the frequency really drops before we allow turning off the clock. I'm not sure if we can trust that the frequency (and more importantly the voltage) will drop if we allow turning off the clock before the transition is complete. > vlv_force_gfx_clock(dev_priv, false); > = > I915_WRITE(GEN6_PMINTRMSK, > -- = > 1.8.3.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC