From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 01/15] drm/i915: Use named initializers for
 gmch wm params
Date: Fri, 6 Jun 2014 18:38:23 +0200
Message-ID: <20140606163823.GI7416@phenom.ffwll.local>
References: <1401984964-25441-1-git-send-email-ville.syrjala@linux.intel.com>
 <1401984964-25441-2-git-send-email-ville.syrjala@linux.intel.com>
 <20140605204312.GA15324@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
 [74.125.82.175])
 by gabe.freedesktop.org (Postfix) with ESMTP id 10DAC6EA8F
 for <intel-gfx@lists.freedesktop.org>; Fri,  6 Jun 2014 09:38:27 -0700 (PDT)
Received: by mail-we0-f175.google.com with SMTP id p10so3153211wes.34
 for <intel-gfx@lists.freedesktop.org>; Fri, 06 Jun 2014 09:38:27 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140605204312.GA15324@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org, Thomas Richter <richter@rus.uni-stuttgart.de>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jun 05, 2014 at 09:43:12PM +0100, Chris Wilson wrote:
> On Thu, Jun 05, 2014 at 07:15:50PM +0300, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Using names initializers when filling out the watermark structs
> > saves you from having go look up the struct definition every
> > single time.
> > =

> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Thank you,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

My rusty "fix watermarks for gen2/3" wip branch had this too.
Queued for -next, thanks for the patch.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch