From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Only wait one vblank when disabling crc if the pipe is on
Date: Fri, 6 Jun 2014 19:40:04 +0200 [thread overview]
Message-ID: <20140606174004.GQ7416@phenom.ffwll.local> (raw)
In-Reply-To: <20140606171800.GE30042@strange.icx.intel.com>
On Fri, Jun 06, 2014 at 06:18:01PM +0100, Damien Lespiau wrote:
> On Fri, Jun 06, 2014 at 08:22:08AM +0200, Daniel Vetter wrote:
> > + mutex_lock(&crtc->base.mutex);
> > + if (crtc->active)
> > + intel_wait_for_vblank(dev, pipe);
> > + mutex_unlock(&crtc->base.mutex);
>
> drivers/gpu/drm/i915/i915_debugfs.c: In function ‘pipe_crc_set_source’:
> drivers/gpu/drm/i915/i915_debugfs.c:2932:3: warning: passing argument 1 of ‘mutex_lock’ from incompatible pointer type [enabled by default]
> mutex_lock(&crtc->base.mutex);
> ^
> In file included from include/linux/seq_file.h:7:0,
> from drivers/gpu/drm/i915/i915_debugfs.c:29:
> include/linux/mutex.h:158:13: note: expected ‘struct mutex *’ but argument is of type ‘struct drm_modeset_lock *’
> extern void mutex_lock(struct mutex *lock);
Oh dang, rebase fail. Thanks for helping the blind, will fix asap.
-Daniel
> ^
>
> --
> Damien
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-06-06 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 6:22 [PATCH] drm/i915: Only wait one vblank when disabling crc if the pipe is on Daniel Vetter
2014-06-06 8:57 ` Ville Syrjälä
2014-06-06 9:36 ` Daniel Vetter
2014-06-06 17:18 ` Damien Lespiau
2014-06-06 17:40 ` Daniel Vetter [this message]
2014-06-13 12:08 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606174004.GQ7416@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox