From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org" <Intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: revert intel_dp_probe_oui call during HPD interrupt handler
Date: Fri, 6 Jun 2014 22:17:54 +0200 [thread overview]
Message-ID: <20140606201754.GW7416@phenom.ffwll.local> (raw)
In-Reply-To: <CAPM=9twPzPfeaBtoZKq4Uxr7PtcKgqwub9oO=HJ-0dqyWLGcbA@mail.gmail.com>
On Sat, Jun 07, 2014 at 06:14:42AM +1000, Dave Airlie wrote:
> My edp panel bits are all cut-n-paste anyways. maybe we should hold the
> edp on for long periods around that whole probing.
We have a delayed put on the edp panel power. So keeping it just around
the bits where we need it doesn't have perf downsides and imo makes it
clearer why we need it - we've had some good amounts of fun in the past
where functions assumed that the panel is on but not all callers ensured
that. We've pushed the edp panel power handling down the callstacks due
to that.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-06-06 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 22:29 [PATCH] drm/i915: revert intel_dp_probe_oui call during HPD interrupt handler clinton.a.taylor
2014-06-05 9:26 ` Daniel Vetter
2014-06-06 9:41 ` Jani Nikula
2014-06-06 18:13 ` Clint Taylor
2014-06-06 19:54 ` Jani Nikula
2014-06-06 20:14 ` Dave Airlie
2014-06-06 20:17 ` Daniel Vetter [this message]
2014-06-06 16:36 ` Clint Taylor
[not found] ` <5390AB8D.4080908@outlook.or.com>
2014-06-06 17:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606201754.GW7416@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=airlied@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox