Re: [PATCH 01/15] drm/i915: Use named initializers for gmch wm params

Thomas Richter
2014-06-05T21:02:13Z

Am 05.06.2014 22:43, schrieb Chris Wilson:
> On Thu, Jun 05, 2014 at 07:15:50PM +0300, ville.syrjala@linux.intel.com wrote:
>> From: Ville Syrjälä<ville.syrjala@linux.intel.com>
>>
>> Using names initializers when filling out the watermark structs
>> saves you from having go look up the struct definition every
>> single time.
>>
>> Signed-off-by: Ville Syrjälä<ville.syrjala@linux.intel.com>
>
> Thank you,
> Reviewed-by: Chris Wilson<chris@chris-wilson.co.uk>

Thanks for the patch and for all the work, unfortunately it does not
quite work as presented. I applied the patch correctly to
drm-intel-nightly, and it compiles fine.

However, the following issues exist:

*) If you boot with the kernel parameter vga=792 (i.e. the same console
resolutions as initiated by KMS) the system just hangs with a black
screen. Booting aborts, nothing happens.

*) Watermark settings are *still* not correct. *SIGH*, *sigh*

intel_reg_read 0x20d8
0x20D8 : 0x11F0104

This is a watermark level of 4. As I said multiple times, the watermark
register needs to be *AT LEAST* eight (in numbers, 8) to have a stable
display. It is stable between 8 and 32.

To reproduce, use a panning display with xrandr:

xrandr --output DVI1 --mode 1024x768 --panning 2048x1536

then scroll, and see the display flicker.

Folks, I really appreciate all your effort, but I would be really happy
if my comments on the wrong watermarks wouldn't be continuously ignored.
I submitted patches, twice, thrice... all went into the trash.

Greetings,
Thomas