Re: [PATCH 04/15] drm/i915: ns2501 is on DVOB

Daniel Vetter
2014-06-06T16:57:48Z

On Thu, Jun 05, 2014 at 07:15:53PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On Fujitsu-Siememens S6010 the ns2501 chip is hooked up to DVOB instead
> of DVOC.
>
> FIXME: Maybe need to dig out the correct DVO port from VBT

Well we could have 2 match structs for dvoc and dvob. I guess on Thomas'
X30 it is actually on dvob, otherwise he wouldn't have picked that one ...
-Daniel

>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dvo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
> index 5d7d975..be560bb 100644
> --- a/drivers/gpu/drm/i915/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/intel_dvo.c
> @@ -85,7 +85,7 @@ static const struct intel_dvo_device intel_dvo_devices[] = {
> {
> .type = INTEL_DVO_CHIP_TMDS,
> .name = "ns2501",
> - .dvo_reg = DVOC,
> + .dvo_reg = DVOB,
> .slave_addr = NS2501_ADDR,
> .dev_ops = &ns2501_ops,
> }
> --
> 1.8.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch