From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix VLV CRC reading. Date: Tue, 10 Jun 2014 09:05:38 +0200 Message-ID: <20140610070538.GE5821@phenom.ffwll.local> References: <1402003697-1671-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 6003E89BE8 for ; Tue, 10 Jun 2014 00:05:44 -0700 (PDT) Received: by mail-wg0-f49.google.com with SMTP id y10so946286wgg.8 for ; Tue, 10 Jun 2014 00:05:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402003697-1671-1-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 05, 2014 at 02:28:17PM -0700, Rodrigo Vivi wrote: > Adding missing Display mmio reg offset. > > Credits-to: Laws, Philip > Cc: He, Shuang > Signed-off-by: Rodrigo Vivi Is there no bugzilla that pipe crc tests on DP/eDP ports aren't working on byt? Can you please chase this down with QA? Patch is queued for -next. Thanks, Daniel > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 286f05c..05e2541 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -2627,7 +2627,7 @@ enum punit_power_well { > > #define PORT_DFT_I9XX 0x61150 > #define DC_BALANCE_RESET (1 << 25) > -#define PORT_DFT2_G4X 0x61154 > +#define PORT_DFT2_G4X (dev_priv->info.display_mmio_offset + 0x61154) > #define DC_BALANCE_RESET_VLV (1 << 31) > #define PIPE_SCRAMBLE_RESET_MASK (0x3 << 0) > #define PIPE_B_SCRAMBLE_RESET (1 << 1) > -- > 1.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch