From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/3] drm/i915: Check for a stalled page flip
 after each vblank
Date: Tue, 10 Jun 2014 15:26:14 +0200
Message-ID: <20140610132614.GL5821@phenom.ffwll.local>
References: <1402394642-6263-1-git-send-email-chris@chris-wilson.co.uk>
 <20140610112550.GX27580@intel.com>
 <20140610113348.GA22223@nuc-i3427.alporthouse.com>
 <20140610114729.GA27580@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f169.google.com (mail-we0-f169.google.com
 [74.125.82.169])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8C2526E00A
 for <intel-gfx@lists.freedesktop.org>; Tue, 10 Jun 2014 06:26:22 -0700 (PDT)
Received: by mail-we0-f169.google.com with SMTP id t60so2235966wes.0
 for <intel-gfx@lists.freedesktop.org>; Tue, 10 Jun 2014 06:26:21 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140610114729.GA27580@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jun 10, 2014 at 02:47:29PM +0300, Ville Syrj=E4l=E4 wrote:
> On Tue, Jun 10, 2014 at 12:33:48PM +0100, Chris Wilson wrote:
> > On Tue, Jun 10, 2014 at 02:25:50PM +0300, Ville Syrj=E4l=E4 wrote:
> > > On Tue, Jun 10, 2014 at 11:04:00AM +0100, Chris Wilson wrote:
> > > > +static inline int crtc_sbc(struct intel_crtc *crtc)
> > > > +{
> > > > +	return atomic_read(&crtc->base.dev->vblank[crtc->pipe].count);
> > > > +}
> > > =

> > > Still says 'sbc' which doesn't make sense to me.
> > =

> > I just don't like the term msc. :-p
> > crtc_vblank_counter()?
> =

> Maybe stick it into drmP.h and call it drm_crtc_vblank_counter() or
> something? Hopefully people won't confuse it with the hardware counter.

It's called drm_vblank_count, but a new wrapper which takes a drm_crtc *
as the argument would indeed be nice. So drm_crtc_vblank_counter(struct
drm_crtc *crtc). And please don't forget to add the kerneldoc and to pull
it into the drm docbook.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch