From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only
Date: Tue, 10 Jun 2014 20:16:28 +0300 [thread overview]
Message-ID: <20140610171628.GF27580@intel.com> (raw)
In-Reply-To: <87ha3su6bp.fsf@intel.com>
On Tue, Jun 10, 2014 at 06:34:18PM +0300, Jani Nikula wrote:
> On Tue, 10 Jun 2014, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Mon, 09 Jun 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> >> On Mon, Jun 09, 2014 at 10:06:49AM -0700, Tom.O'Rourke@intel.com wrote:
> >>> From: Tom O'Rourke <Tom.O'Rourke@intel.com>
> >>>
> >>> In gen8_enable_rps, don't write CHV registers unless IS_CHERRYVIEW.
> >>>
> >>> Signed-off-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
> >>
> >> A lovely catch.
> >
> > Sadly gen8_enable_rps does not get called on chv, so the fix is wrong.
>
> To elaborate, I think we need a patch dropping the wa altogether (which
> we can queue for 3.15 through stable because the change affects
> broadwell) and another patch, if needed, adding the wa in the chv
> specific function.
This is just a merge mishap in one the chv patches. Someone just
needs to send a patch that moves the misapplied stuff to the
appropriate chv function.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-06-10 17:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 17:06 [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only Tom.O'Rourke
2014-06-09 17:32 ` Damien Lespiau
2014-06-10 15:30 ` Jani Nikula
2014-06-10 15:34 ` Jani Nikula
2014-06-10 17:16 ` Ville Syrjälä [this message]
2014-06-10 18:17 ` Jani Nikula
2014-06-10 19:03 ` O'Rourke, Tom
2014-06-10 19:15 ` Ville Syrjälä
2014-06-10 23:26 ` [PATCH] drm/i915/chv: Fix "drm/i915/chv: Add a bunch of pre production workarounds" Tom.O'Rourke
2014-06-12 8:20 ` Ville Syrjälä
2014-06-12 10:35 ` Daniel Vetter
2014-06-12 10:33 ` [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only Jani Nikula
2014-06-12 12:42 ` Daniel Vetter
2014-06-13 8:35 ` [PATCH] drm/i915/bdw: remove erroneous chv specific workarounds from bdw code Jani Nikula
2014-06-13 8:53 ` Jani Nikula
2014-06-13 15:55 ` O'Rourke, Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610171628.GF27580@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox