From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: drm/i915/bdw: Enable resource streamer on Broadwell Date: Wed, 11 Jun 2014 11:10:10 -0700 Message-ID: <20140611111010.66c1f01f@jbarnes-desktop> References: <1399404306-26834-1-git-send-email-abdiel.janulgue@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 05A976E88D for ; Wed, 11 Jun 2014 11:09:59 -0700 (PDT) Received: by mail-pb0-f41.google.com with SMTP id ma3so73468pbc.14 for ; Wed, 11 Jun 2014 11:09:58 -0700 (PDT) In-Reply-To: <1399404306-26834-1-git-send-email-abdiel.janulgue@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Abdiel Janulgue Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 6 May 2014 22:25:04 +0300 Abdiel Janulgue wrote: > From: Abdiel Janulgue > > This is a re-spin of my resource streamer patchset from October > adapted to enable the feature on Broadwell instead. > > The resource streamer is a hw-feature that helps in reducing commands > being submitted by the CPU. Haswell initially has this feature. > Unfortunately, HSW seems to have problems switching between non-RS > and RS-enabled commands[1]. On BDW however it works seamlessly > as expected. > > The i-g-t test comes next on a separate patch-series. > > -- > [1] http://lists.freedesktop.org/archives/intel-gfx/2014-May/044577.html > > Abdiel Janulgue (2): > drm/i915/bdw: Enable resource streamer bits on MI_BATCH_BUFFER_START > drm/i915/bdw: Expose I915_EXEC_RESOURCE_STREAMER flag > > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 ++++++++ > drivers/gpu/drm/i915/i915_reg.h | 1 + > drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++- > drivers/gpu/drm/i915/intel_ringbuffer.h | 1 + > include/uapi/drm/i915_drm.h | 7 ++++++- > 5 files changed, 18 insertions(+), 2 deletions(-) These seem trivial enough... have you seen cases where you'd like to enable it in Mesa? If so, it probably makes sense to merge this patch so you can do your tuning and enabling on the Mesa side... -- Jesse Barnes, Intel Open Source Technology Center