From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt 1/4] lib/igt_debugfs: Don't fail if debugfs is already mounted
Date: Thu, 12 Jun 2014 09:20:09 +0200 [thread overview]
Message-ID: <20140612072009.GS5821@phenom.ffwll.local> (raw)
In-Reply-To: <1402504880-27525-1-git-send-email-ville.syrjala@linux.intel.com>
On Wed, Jun 11, 2014 at 07:41:17PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Remove the igt_assert() from the debugfs mount. It will fail if debugfs
> is already mounted. With the assert in place it's very annying to use
> igt without i915 loaded (eg. to dump BIOS configured registers).
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
> index f21f671..809d447 100644
> --- a/lib/igt_debugfs.c
> +++ b/lib/igt_debugfs.c
> @@ -102,7 +102,7 @@ static bool __igt_debugfs_init(igt_debugfs_t *debugfs)
>
> igt_assert(stat("/sys/kernel/debug", &st) == 0);
>
> - igt_assert(mount("debug", "/sys/kernel/debug", "debugfs", 0, 0) == 0);
> + mount("debug", "/sys/kernel/debug", "debugfs", 0, 0);
Hm, for me this just silently succeeds. Maybe just an igt_warn_on? But I'm
ok with this here, too.
-Daniel
>
> find_minor:
> strcpy(debugfs->root, path);
> --
> 1.8.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-06-12 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 16:41 [PATCH igt 1/4] lib/igt_debugfs: Don't fail if debugfs is already mounted ville.syrjala
2014-06-11 16:41 ` [PATCH igt 2/4] lib/igt_debufs: Add IGT_NO_FORCEWAKE environment variable ville.syrjala
2014-06-11 16:41 ` [PATCH igt 3/4] tools: Add intel_iosf_sb_{read, write} tools ville.syrjala
2014-06-11 16:41 ` [PATCH igt 4/4] tools/intel_poller: Add a new tool that will poll various display registers ville.syrjala
2014-06-12 7:21 ` Daniel Vetter
2014-06-12 7:20 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612072009.GS5821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox