From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH igt 1/4] lib/igt_debugfs: Don't fail if debugfs is already mounted Date: Thu, 12 Jun 2014 09:20:09 +0200 Message-ID: <20140612072009.GS5821@phenom.ffwll.local> References: <1402504880-27525-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-we0-f178.google.com (mail-we0-f178.google.com [74.125.82.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 25D726E4D4 for ; Thu, 12 Jun 2014 00:20:16 -0700 (PDT) Received: by mail-we0-f178.google.com with SMTP id x48so71461wes.37 for ; Thu, 12 Jun 2014 00:20:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402504880-27525-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jun 11, 2014 at 07:41:17PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > Remove the igt_assert() from the debugfs mount. It will fail if debugfs > is already mounted. With the assert in place it's very annying to use > igt without i915 loaded (eg. to dump BIOS configured registers). > = > Signed-off-by: Ville Syrj=E4l=E4 > --- > lib/igt_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c > index f21f671..809d447 100644 > --- a/lib/igt_debugfs.c > +++ b/lib/igt_debugfs.c > @@ -102,7 +102,7 @@ static bool __igt_debugfs_init(igt_debugfs_t *debugfs) > = > igt_assert(stat("/sys/kernel/debug", &st) =3D=3D 0); > = > - igt_assert(mount("debug", "/sys/kernel/debug", "debugfs", 0, 0) =3D=3D = 0); > + mount("debug", "/sys/kernel/debug", "debugfs", 0, 0); Hm, for me this just silently succeeds. Maybe just an igt_warn_on? But I'm ok with this here, too. -Daniel > = > find_minor: > strcpy(debugfs->root, path); > -- = > 1.8.5.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch