From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "S, Deepak" <deepak.s@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vlv: drop punit freq staus read after setting idle
Date: Thu, 12 Jun 2014 21:40:32 +0300 [thread overview]
Message-ID: <20140612184032.GW27580@intel.com> (raw)
In-Reply-To: <5399EE27.4020701@intel.com>
On Thu, Jun 12, 2014 at 11:45:03PM +0530, S, Deepak wrote:
> >> I was polling VLV_GTLC_SURVIVABILITY_REG and VLV_GTLC_PW_STATUS to make
> >> sure both render and media wells and the gfx clock remain off, and I
> >> was also monitoring vnn via svid. While that was going on I just rewrote
> >> PUNIT_REG_GPU_FREQ_REQ to make Punit change the frequency, and sure
> >> enough it did, and svid showed me that vnn had also changed. So it
> >> appears there's no need to have the gfx clock on to change its frequency
> >> on this BYT.
> >>
> >> I wonder if this part of the workaround was only needed on older parts.
> >> Deepak, any ideas?
> >
> > Yes ville, this was added initial for older parts and force gfx clock
> > was part of the workaround.
> > We have not verified this on newer parts. Let me check with hw guys to
> > see if workaround still exits and when this was fixed.
>
> Hi Ville, Got the confirmation from HW team, this WA as been fixed in
> latest stepping,
What's latest here? Did we ever ship any of the steppings that still
need the gfx clock force?
> we can remove the force gfx clock, mask and request
> only the min freq when we are idle.
>
> You will submit patch will fix or you want me to do it?
Go ahead if you have time. I'm already juggling too many things :)
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-06-12 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 20:49 [PATCH] drm/i915/vlv: drop punit freq staus read after setting idle Jesse Barnes
2014-06-06 8:29 ` Ville Syrjälä
2014-06-06 15:03 ` Jesse Barnes
2014-06-11 16:56 ` Ville Syrjälä
2014-06-12 2:44 ` S, Deepak
2014-06-12 7:37 ` Lee, Chon Ming
2014-06-12 8:08 ` Daniel Vetter
2014-06-12 8:11 ` Ville Syrjälä
2014-06-12 8:19 ` Lee, Chon Ming
2014-06-12 18:15 ` S, Deepak
2014-06-12 18:40 ` Ville Syrjälä [this message]
2014-06-12 18:41 ` S, Deepak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612184032.GW27580@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox