From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/vlv: drop punit freq staus read
 after setting idle
Date: Thu, 12 Jun 2014 21:40:32 +0300
Message-ID: <20140612184032.GW27580@intel.com>
References: <1402001374-2657-1-git-send-email-jbarnes@virtuousgeek.org>
 <20140606082924.GD27580@intel.com>
 <20140606080320.20fcd778@jbarnes-desktop>
 <20140611165611.GM27580@intel.com> <53991407.1090402@intel.com>
 <5399EE27.4020701@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by gabe.freedesktop.org (Postfix) with ESMTP id 636F96E962
 for <intel-gfx@lists.freedesktop.org>; Thu, 12 Jun 2014 11:40:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <5399EE27.4020701@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "S, Deepak" <deepak.s@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jun 12, 2014 at 11:45:03PM +0530, S, Deepak wrote:
>  >> I was polling VLV_GTLC_SURVIVABILITY_REG and VLV_GTLC_PW_STATUS to ma=
ke
>  >> sure both render and media wells and the gfx clock remain off, and I
>  >> was also monitoring vnn via svid. While that was going on I just rewr=
ote
>  >> PUNIT_REG_GPU_FREQ_REQ to make Punit change the frequency, and sure
>  >> enough it did, and svid showed me that vnn had also changed. So it
>  >> appears there's no need to have the gfx clock on to change its freque=
ncy
>  >> on this BYT.
>  >>
>  >> I wonder if this part of the workaround was only needed on older part=
s.
>  >> Deepak, any ideas?
>  >
>  > Yes ville, this was added initial for older parts and force gfx clock
>  > was part of the workaround.
>  > We have not verified this on newer parts. Let me check with hw guys to
>  > see if workaround still exits and when this was fixed.
> =

> Hi Ville, Got the confirmation from HW team, this WA as been fixed in =

> latest stepping,

What's latest here? Did we ever ship any of the steppings that still
need the gfx clock force?

> we can remove the force gfx clock, mask and request =

> only the min freq when we are idle.
> =

> You will submit patch will fix or you want me to do it?

Go ahead if you have time. I'm already juggling too many things :)

-- =

Ville Syrj=E4l=E4
Intel OTC