From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] igt/gem_partial_pwrite_pread: Add set-cache subtest to validate JIRA VIZ-3721 Date: Fri, 13 Jun 2014 09:13:51 +0200 Message-ID: <20140613071351.GE5821@phenom.ffwll.local> References: <1402607917-12847-1-git-send-email-armin.c.reese@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 27AB46E9B7 for ; Fri, 13 Jun 2014 00:13:58 -0700 (PDT) Received: by mail-wi0-f175.google.com with SMTP id r20so329101wiv.14 for ; Fri, 13 Jun 2014 00:13:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402607917-12847-1-git-send-email-armin.c.reese@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: armin.c.reese@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 12, 2014 at 02:18:37PM -0700, armin.c.reese@intel.com wrote: > From: Armin Reese > > This subtest forces the driver down the code path in i915_gem_object_set_cache_level() > which unbinds VMAs and triggers the kernel panic described in VIZ-3721. This > test will pass if the bug fix is in place. > > Bugzilla: https://bugs.fredesktop.org/show_bug.cgi?id=76384 > Signed-off-by: Armin Reese > --- > tests/gem_partial_pwrite_pread.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/gem_partial_pwrite_pread.c b/tests/gem_partial_pwrite_pread.c > index 7945ba7..3e3ecc9 100644 > --- a/tests/gem_partial_pwrite_pread.c > +++ b/tests/gem_partial_pwrite_pread.c > @@ -131,6 +131,14 @@ static void test_partial_reads(void) > > } > > +static void test_set_cache(void) > +{ > + igt_info("checking set-cache\n"); > + > + blt_bo_fill(staging_bo, scratch_bo, 0); > + > +} Ok, my apologies for the unclear JIRA description. My idea was to have a tailor-made testcase with a minimal reproduction scenario (i.e. map into 2 ppgtt or ggtt + ppgtt, then do a set_caching ioctl). This here blows up because we do the set_caching as part of the fixture, so has a high risk that when someone decides to refactor the testcase we'll no longer test this bug. Hence the task to create a new, specific testcase. -Daniel > + > static void test_partial_writes(void) > { > int i, j; > @@ -244,6 +252,9 @@ static void do_tests(int cache_level, const char *suffix) > gem_set_caching(fd, scratch_bo->handle, cache_level); > } > > + igt_subtest_f("set-cache%s", suffix) > + test_set_cache(); > + > igt_subtest_f("reads%s", suffix) > test_partial_reads(); > > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch