From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs Date: Fri, 13 Jun 2014 18:54:02 +0300 Message-ID: <20140613155402.GA27580@intel.com> References: <1402673558-15618-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FF396EA88 for ; Fri, 13 Jun 2014 08:54:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402673558-15618-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote: > Early revs didn't have PPGTT support, so disable there. > = > References: https://bugs.freedesktop.org/show_bug.cgi?id=3D79669 > References: https://bugs.freedesktop.org/show_bug.cgi?id=3D79670 > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++ > 1 file changed, 4 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i= 915_gem_gtt.c > index 8b3cde7..01287d9 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *de= v, int enable_ppgtt) > } > #endif > = > + /* Early VLV doesn't have this */ > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc) Did you mean < 0xb? > + return 0; > + > return HAS_ALIASING_PPGTT(dev) ? 1 : 0; > } > = > -- = > 1.7.9.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC