From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs v3
Date: Fri, 13 Jun 2014 18:52:48 +0200
Message-ID: <20140613165248.GU5821@phenom.ffwll.local>
References: <1402673558-15618-1-git-send-email-jbarnes@virtuousgeek.org>
 <1402676913-23012-1-git-send-email-jbarnes@virtuousgeek.org>
 <20140613164550.GC27580@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f179.google.com (mail-we0-f179.google.com
 [74.125.82.179])
 by gabe.freedesktop.org (Postfix) with ESMTP id B36D36E030
 for <intel-gfx@lists.freedesktop.org>; Fri, 13 Jun 2014 09:52:54 -0700 (PDT)
Received: by mail-we0-f179.google.com with SMTP id w62so3019451wes.24
 for <intel-gfx@lists.freedesktop.org>; Fri, 13 Jun 2014 09:52:53 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140613164550.GC27580@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jun 13, 2014 at 07:45:50PM +0300, Ville Syrj=E4l=E4 wrote:
> On Fri, Jun 13, 2014 at 09:28:33AM -0700, Jesse Barnes wrote:
> > Early revs didn't have PPGTT support, so disable there.
> > =

> > v2: add debug msg when disabling on early stepping
> > v3: enable on other B3 packages as well (untested) (Ville)
> > =

> > References: https://bugs.freedesktop.org/show_bug.cgi?id=3D79669
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=3D79670
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> =

> I don't have any affected systems myself, but it did fail for me on
> a pre-production part and the evidence from the bugs is strong, so:
> =

> Acked-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel

> =

> > ---
> >  drivers/gpu/drm/i915/i915_gem_gtt.c |    6 ++++++
> >  1 file changed, 6 insertions(+)
> > =

> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915=
/i915_gem_gtt.c
> > index 8b3cde7..7f226fa 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -63,6 +63,12 @@ static int sanitize_enable_ppgtt(struct drm_device *=
dev, int enable_ppgtt)
> >  	}
> >  #endif
> >  =

> > +	/* Early VLV doesn't have this */
> > +	if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xb) {
> > +		DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n");
> > +		return 0;
> > +	}
> > +
> >  	return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
> >  }
> >  =

> > -- =

> > 1.7.9.5
> > =

> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> =

> -- =

> Ville Syrj=E4l=E4
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch