From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 51/53] drm/i915/bdw: Document Logical Rings, LR contexts and Execlists Date: Mon, 16 Jun 2014 19:56:00 +0200 Message-ID: <20140616175600.GA5821@phenom.ffwll.local> References: <1402673891-14618-1-git-send-email-oscar.mateo@intel.com> <1402673891-14618-52-git-send-email-oscar.mateo@intel.com> <20140613165116.GN6451@nuc-i3427.alporthouse.com> <92648605EABDA246B775AAB04C95A7A30131B63B@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 0033A6E5B0 for ; Mon, 16 Jun 2014 10:56:07 -0700 (PDT) Received: by mail-we0-f173.google.com with SMTP id t60so6111530wes.32 for ; Mon, 16 Jun 2014 10:56:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <92648605EABDA246B775AAB04C95A7A30131B63B@IRSMSX103.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Mateo Lozano, Oscar" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Mon, Jun 16, 2014 at 03:24:26PM +0000, Mateo Lozano, Oscar wrote: > > -----Original Message----- > > From: Chris Wilson [mailto:chris@chris-wilson.co.uk] > > Sent: Friday, June 13, 2014 5:51 PM > > To: Mateo Lozano, Oscar > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 51/53] drm/i915/bdw: Document Logical > > Rings, LR contexts and Execlists > > > > On Fri, Jun 13, 2014 at 04:38:09PM +0100, oscar.mateo@intel.com wrote: > > > +/** > > > + * intel_execlists_ctx_id() - get the Execlists Context ID > > > + * @ctx_obj: Logical Ring Context backing object. > > > + * > > > + * Do not confuse with ctx->id! Unfortunately we have a name overload > > > + * here: the old context ID we pass to userspace as a handler so that > > > + * they can refer to a context, and the new context ID we pass to the > > > + * ELSP so that the GPU can inform us of the context status via > > > + * interrupts. > > > + * > > > + * Return: 20-bits globally unique context ID. > > > + */ > > > > Use tag for the ctx id we pass around in hw? > > -Chris > > I also tried other names, like "submission id", but it confuses people > when they search for in the BSpec. Maybe changing ctx->id to ctx->tag, > and leaving id for the hardware? I think Chris' idea was to reuse the id from the idr for the hw tag. But I guess that fails because our idr is global. Or I'm totally confused. I'd vote for hw_ctx_id or something. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch