public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Wendy Wang <wendy.wang@intel.com>
Cc: Paul Parenteau <paul.a.parenteau@intel.com>,
	intel-gfx@lists.freedesktop.org, lei.a.liu@intel.com,
	gordon.jin@intel.com
Subject: Re: [PATCH] Fixed the review issues for pm_rc6_residency IGT case
Date: Mon, 16 Jun 2014 11:43:30 -0700	[thread overview]
Message-ID: <20140616184330.GB1718@intel.com> (raw)
In-Reply-To: <1402303007-25566-1-git-send-email-wendy.wang@intel.com>

Hi Wendy. Daniel has reverted your original commit here:
commit 35554a1bcaaea55c1cfa88c0176c58d2fb3b8013
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Jun 10 11:05:16 2014 +0200

    Revert "Add rc6_residency_counter subtest"

Note that I absolutely do not agree with the decision to revert your
patch as was stated in the commit message. I am not sure how Daniel got
the impression that I thought this was "in order."

Can you please resubmit the patch based on the latest intel-gpu-tools?

-- 
Ben Widawsky, Intel Open Source Technology Center

  parent reply	other threads:[~2014-06-16 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09  8:36 [PATCH] Fixed the review issues for pm_rc6_residency IGT case Wendy Wang
2014-06-10  9:12 ` Daniel Vetter
2014-06-16 18:43 ` Ben Widawsky [this message]
2014-06-16 20:38   ` Jesse Barnes
2014-06-16 21:55     ` Daniel Vetter
2014-06-16 22:03       ` Jesse Barnes
2014-06-17  7:21         ` Daniel Vetter
2014-06-16 21:57 ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140616184330.GB1718@intel.com \
    --to=benjamin.widawsky@intel.com \
    --cc=gordon.jin@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lei.a.liu@intel.com \
    --cc=paul.a.parenteau@intel.com \
    --cc=wendy.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox