From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v5] drm/i915: Added write-enable pte bit support Date: Tue, 17 Jun 2014 09:22:07 +0200 Message-ID: <20140617072207.GN5821@phenom.ffwll.local> References: <1402948214.5147.9.camel@ideak-mobl> <1402982982-7185-1-git-send-email-akash.goel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 484B16E632 for ; Tue, 17 Jun 2014 00:22:15 -0700 (PDT) Received: by mail-wi0-f176.google.com with SMTP id n3so5251862wiv.9 for ; Tue, 17 Jun 2014 00:22:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402982982-7185-1-git-send-email-akash.goel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: akash.goel@intel.com Cc: intel-gfx@lists.freedesktop.org, sourab.gupta@intel.com List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 17, 2014 at 10:59:42AM +0530, akash.goel@intel.com wrote: > From: Akash Goel > > This adds support for a write-enable bit in the entry of GTT. > This is handled via a read-only flag in the GEM buffer object which > is then used to see how to set the bit when writing the GTT entries. > Currently by default the Batch buffer & Ring buffers are marked as read only. > > v2: Moved the pte override code for read-only bit to 'byt_pte_encode'. (Chris) > Fixed the issue of leaving 'gt_old_ro' as unused. (Chris) > > v3: Removed the 'gt_old_ro' field, now setting RO bit only for Ring Buffers(Daniel). > > v4: Added a new 'flags' parameter to all the pte(gen6) encode & insert_entries functions, > in lieu of overloading the cache_level enum (Daniel). > > v5: Removed the superfluous VLV check & changed the definition location of PTE_READ_ONLY flag (Imre) > > Reviewed-by: Imre Deak > Signed-off-by: Akash Goel Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch