From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 04/15] drm/i915: Run psr_setup
	unconditionally
Date: Tue, 17 Jun 2014 09:23:48 +0200
Message-ID: <20140617072348.GO5821@phenom.ffwll.local>
References: <1402941095-27879-1-git-send-email-daniel.vetter@ffwll.ch>
 <1402941095-27879-5-git-send-email-daniel.vetter@ffwll.ch>
 <CABVU7+uxDf6VAXmND1jjGLPUbv-4EAm1yA1pLXGCz1x-0YxvuA@mail.gmail.com>
 <20140617064353.GB17744@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4B6366E635
 for <intel-gfx@lists.freedesktop.org>; Tue, 17 Jun 2014 00:23:56 -0700 (PDT)
Received: by mail-wi0-f179.google.com with SMTP id cc10so5240022wib.6
 for <intel-gfx@lists.freedesktop.org>; Tue, 17 Jun 2014 00:23:55 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140617064353.GB17744@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Rodrigo Vivi <rodrigo.vivi@gmail.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jun 17, 2014 at 07:43:53AM +0100, Chris Wilson wrote:
> On Mon, Jun 16, 2014 at 05:03:02PM -0700, Rodrigo Vivi wrote:
> >    On Mon, Jun 16, 2014 at 10:51 AM, Daniel Vetter
> >    <[1]daniel.vetter@ffwll.ch> wrote:
> > =

> >      =A0static void intel_edp_psr_enable_sink(struct intel_dp *intel_dp)
> >      @@ -1911,9 +1906,6 @@ void intel_edp_psr_exit(struct drm_device *d=
ev,
> >      bool schedule_back)
> >      =A0 =A0 =A0 =A0 if (!HAS_PSR(dev))
> >      =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return;
> =

> Whilst you are here, this should just be a if (dev_priv->psr.enabled)
> check.

I have fixup for psr_invalidate/psr_flush, as this ends up being called to
do exactly that. It blew up ;-)
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch