From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 14/15] drm/i915: Track frontbuffer invalidation/flushing Date: Tue, 17 Jun 2014 09:33:24 +0200 Message-ID: <20140617073324.GT5821@phenom.ffwll.local> References: <1402941095-27879-1-git-send-email-daniel.vetter@ffwll.ch> <1402941095-27879-15-git-send-email-daniel.vetter@ffwll.ch> <20140617064646.GC17744@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EE846E410 for ; Tue, 17 Jun 2014 00:33:32 -0700 (PDT) Received: by mail-wi0-f176.google.com with SMTP id n3so5271301wiv.3 for ; Tue, 17 Jun 2014 00:33:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140617064646.GC17744@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , Intel Graphics Development , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 17, 2014 at 07:46:46AM +0100, Chris Wilson wrote: > On Mon, Jun 16, 2014 at 07:51:34PM +0200, Daniel Vetter wrote: > > void i915_gem_release(struct drm_device *dev, struct drm_file *file) > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > > index 93d7f7246588..2d06aad4a954 100644 > > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > > @@ -978,7 +978,7 @@ i915_gem_execbuffer_move_to_active(struct list_head *vmas, > > /* check for potential scanout */ > > if (i915_gem_obj_ggtt_bound(obj) && > > i915_gem_obj_to_ggtt(obj)->pin_count) > > What is it about these checks you like so much? You haven't taken the > patches to convert this to if (obj->pin_display) and you haven't > converted them to obj->frontbuffer_bits in this patch either! Just didn't touch them. But yeah, these should be converted to obj->frontbuffer_bits I guess. -Daniel > > > - intel_mark_fb_busy(obj, ring); > > + intel_fb_invalidate(obj, ring); > > > > /* update for the implicit flush after a batch */ > > obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS; > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch