From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 14/15] drm/i915: Track frontbuffer
 invalidation/flushing
Date: Tue, 17 Jun 2014 09:39:24 +0200
Message-ID: <20140617073924.GW5821@phenom.ffwll.local>
References: <1402941095-27879-1-git-send-email-daniel.vetter@ffwll.ch>
 <1402941095-27879-15-git-send-email-daniel.vetter@ffwll.ch>
 <20140617065225.GF17744@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178])
 by gabe.freedesktop.org (Postfix) with ESMTP id 865326E459
 for <intel-gfx@lists.freedesktop.org>; Tue, 17 Jun 2014 00:39:32 -0700 (PDT)
Received: by mail-wi0-f178.google.com with SMTP id n15so5266582wiw.5
 for <intel-gfx@lists.freedesktop.org>; Tue, 17 Jun 2014 00:39:31 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140617065225.GF17744@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jun 17, 2014 at 07:52:25AM +0100, Chris Wilson wrote:
> On Mon, Jun 16, 2014 at 07:51:34PM +0200, Daniel Vetter wrote:
> > +static void intel_mark_fb_busy(struct drm_device *dev,
> > +			       unsigned frontbuffer_bits,
> > +			       struct intel_engine_cs *ring)
> >  {
> > -	struct drm_device *dev = obj->base.dev;
> >  	enum pipe pipe;
> >  
> > -	intel_edp_psr_exit(dev);
> > -
> >  	if (!i915.powersave)
> >  		return;
> 
> I think this wants to be moved from here down to
> intel_increase_pllclock. It's a little dangerous here as we use it
> inconsistently, and we certainly want to keep tracking fb bits for other
> reasons.

powersave was originally the overall blocker for all things power saving
related. We already have separate knobs for all real features, so I guess
we could just rip this out - it doesn't actually guard much of anything,
is inconsistent and always enabled anyway.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch