Re: [PATCH 14/15] drm/i915: Track frontbuffer invalidation/flushing

Chris Wilson
2014-06-17T07:00:12Z

On Mon, Jun 16, 2014 at 07:51:34PM +0200, Daniel Vetter wrote:
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index b8359f4a6dc4..dfdbf2a02844 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2755,6 +2755,8 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
>
> dev_priv->display.update_primary_plane(crtc, fb, x, y);
>
> + intel_frontbuffer_flush(dev, INTEL_FRONTBUFFER_PRIMARY(pipe));

Conceptually all of these are just intel_fb_flip_complete. It may be
easier in your tracking scheme to have:

intel_fb_flip() { intel_fb_flip_prepare(); intel_fb_fip_complete(); }
-Chris

--
Chris Wilson, Intel Open Source Technology Centre