Re: [PATCH 04/15] drm/i915: Run psr_setup unconditionally

Daniel Vetter
2014-06-17T07:23:56Z

On Tue, Jun 17, 2014 at 07:43:53AM +0100, Chris Wilson wrote:
> On Mon, Jun 16, 2014 at 05:03:02PM -0700, Rodrigo Vivi wrote:
> > On Mon, Jun 16, 2014 at 10:51 AM, Daniel Vetter
> > <[1]daniel.vetter@ffwll.ch> wrote:
> >
> >  static void intel_edp_psr_enable_sink(struct intel_dp *intel_dp)
> > @@ -1911,9 +1906,6 @@ void intel_edp_psr_exit(struct drm_device *dev,
> > bool schedule_back)
> >         if (!HAS_PSR(dev))
> >                 return;
>
> Whilst you are here, this should just be a if (dev_priv->psr.enabled)
> check.

I have fixup for psr_invalidate/psr_flush, as this ends up being called to
do exactly that. It blew up ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch