From: Damien Lespiau <damien.lespiau@intel.com>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/11] tests/kms_rotation_crc: IGT for 180 degree HW rotation
Date: Wed, 18 Jun 2014 12:32:00 +0100 [thread overview]
Message-ID: <20140618113200.GD18833@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1403081847-4364-12-git-send-email-sonika.jindal@intel.com>
On Wed, Jun 18, 2014 at 02:27:27PM +0530, sonika.jindal@intel.com wrote:
> From: Sonika Jindal <sonika.jindal@intel.com>
>
> Testcase for 180 degree HW rotation
>
> Cc: sagar.a.kamble@intel.com
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
The test looks good to me (I haven't checked in details, the bar for igt
is quite a bit lower). It shows two gaps in the igt kms API:
- Retrieving the primary plane (there's a series from Matt fixing this
and exposing the primary plane through igt_output_get_plane())
- Adding a set_property() convenience function
(ala igt_plane_set_property("rotation", BIT(DRM_ROTATE_180)))
(no-one is working on that just yet, can de done later)
A small question before pushing this, have you checked that the test
correctly skips when running with a kernel without rotation support?
Thanks,
--
Damien
next prev parent reply other threads:[~2014-06-18 11:32 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 8:57 [PATCH 00/11] Support for 180 degree HW rotation sonika.jindal
2014-06-18 8:57 ` [PATCH 01/11] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h sonika.jindal
2014-06-18 8:57 ` [PATCH 02/11] drm: Add support_bits parameter to drm_property_create_bitmask() sonika.jindal
2014-06-18 8:57 ` [PATCH 03/11] drm: Add drm_mode_create_rotation_property() sonika.jindal
2014-06-18 8:57 ` [PATCH 04/11] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() sonika.jindal
2014-06-18 8:57 ` [PATCH 05/11] drm: Add drm_rect rotation functions sonika.jindal
2014-06-18 8:57 ` [PATCH 06/11] drm: Add drm_rotation_simplify() sonika.jindal
2014-06-18 8:57 ` [PATCH 07/11] drm/i915: Add 180 degree sprite rotation support sonika.jindal
2014-06-18 8:57 ` [PATCH 08/11] drm/i915: Make intel_plane_restore() return an error sonika.jindal
2014-06-18 8:57 ` [PATCH 09/11] drm/i915: Add rotation property for sprites sonika.jindal
2014-06-18 11:12 ` Damien Lespiau
2014-06-18 11:54 ` Jindal, Sonika
2014-06-18 13:09 ` Damien Lespiau
2014-06-18 12:01 ` Ville Syrjälä
2014-06-18 8:57 ` [PATCH 10/11] drm/i915: Add 180 degree primary plane rotation support sonika.jindal
2014-06-18 17:02 ` Damien Lespiau
2014-06-19 6:43 ` Jindal, Sonika
2014-06-19 7:07 ` Daniel Vetter
2014-06-19 7:52 ` Jindal, Sonika
2014-06-19 7:55 ` Daniel Vetter
2014-06-19 8:09 ` Jindal, Sonika
2014-06-19 8:21 ` Daniel Vetter
2014-06-19 12:39 ` [PATCH] drm: Resetting rotation property sonika.jindal
2014-06-23 5:35 ` [PATCH 0/3] Moving rotation_property to drm_plane sonika.jindal
2014-06-23 5:35 ` [PATCH 1/3] drm/i915: Add rotation property for sprites sonika.jindal
2014-06-23 5:36 ` [PATCH 2/3] drm/i915: Add 180 degree primary plane rotation support sonika.jindal
2014-06-24 10:14 ` Damien Lespiau
2014-06-24 10:26 ` Jindal, Sonika
2014-06-24 10:29 ` Damien Lespiau
2014-06-24 10:34 ` Jindal, Sonika
2014-06-23 5:36 ` [PATCH 3/3] drm: Resetting rotation property sonika.jindal
2014-06-24 10:27 ` Damien Lespiau
2014-06-24 12:08 ` [PATCH 0/3] Moving rotation_property to drm_plane sonika.jindal
2014-06-24 12:08 ` [PATCH 1/3] drm/i915: Add rotation property for sprites sonika.jindal
2014-06-24 12:08 ` [PATCH 2/3] drm/i915: Add 180 degree primary plane rotation support sonika.jindal
2014-06-30 6:12 ` [PATCH] " sonika.jindal
2014-06-24 12:08 ` [PATCH 3/3] drm: Resetting rotation property sonika.jindal
2014-07-02 8:51 ` [PATCH 0/3] Moving rotation_property to drm_plane Jindal, Sonika
2014-07-02 13:17 ` Damien Lespiau
2014-07-07 14:34 ` Daniel Vetter
2014-06-19 10:07 ` [PATCH 10/11] drm/i915: Add 180 degree primary plane rotation support Damien Lespiau
2014-06-19 10:38 ` Daniel Vetter
2014-06-27 10:34 ` Tvrtko Ursulin
2014-06-27 10:49 ` Jindal, Sonika
2014-06-27 11:12 ` Tvrtko Ursulin
2014-06-27 11:14 ` Jindal, Sonika
2014-06-27 10:38 ` Tvrtko Ursulin
2014-06-27 11:15 ` Jindal, Sonika
2014-06-18 8:57 ` [PATCH 11/11] tests/kms_rotation_crc: IGT for 180 degree HW rotation sonika.jindal
2014-06-18 11:32 ` Damien Lespiau [this message]
2014-06-18 11:39 ` Chris Wilson
2014-06-25 5:54 ` Jindal, Sonika
2014-06-25 5:57 ` Chris Wilson
2014-06-25 6:00 ` Jindal, Sonika
2014-06-18 12:00 ` Jindal, Sonika
2014-06-18 11:00 ` [PATCH 00/11] Support " Damien Lespiau
2014-06-18 11:07 ` Chris Wilson
2014-06-18 11:12 ` Damien Lespiau
2014-06-18 11:21 ` Chris Wilson
2014-06-18 11:37 ` Damien Lespiau
2014-06-18 11:57 ` Ville Syrjälä
2014-06-18 11:51 ` Jindal, Sonika
2014-06-19 6:11 ` [PATCH 1/1] Documentation: drm: describing rotation property for i915 sonika.jindal
2014-06-24 10:05 ` Damien Lespiau
2014-06-25 5:38 ` [PATCH 1/2] Documentation: drm: Removing placeholders for generic drm properties description sonika.jindal
2014-06-25 5:38 ` [PATCH 2/2] Documentation: drm: describing rotation property for i915 sonika.jindal
2014-07-02 11:01 ` Damien Lespiau
2014-07-02 11:00 ` [PATCH 1/2] Documentation: drm: Removing placeholders for generic drm properties description Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618113200.GD18833@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox