From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 2/4] drm/i915: Use batch pools with the command parser Date: Wed, 18 Jun 2014 21:59:20 +0200 Message-ID: <20140618195920.GS5821@phenom.ffwll.local> References: <1403109376-23452-1-git-send-email-bradley.d.volkin@intel.com> <1403109376-23452-3-git-send-email-bradley.d.volkin@intel.com> <20140618165252.GX31023@nuc-i3427.alporthouse.com> <20140618174905.GA23789@bdvolkin-ubuntu-desktop> <20140618181146.GY31023@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A08D6E0BC for ; Wed, 18 Jun 2014 12:59:28 -0700 (PDT) Received: by mail-we0-f175.google.com with SMTP id k48so1396683wev.34 for ; Wed, 18 Jun 2014 12:59:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140618181146.GY31023@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , "Volkin, Bradley D" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Wed, Jun 18, 2014 at 07:11:46PM +0100, Chris Wilson wrote: > On Wed, Jun 18, 2014 at 10:49:05AM -0700, Volkin, Bradley D wrote: > > What specifically are you thinking in terms of implementing busy tracking > > in the pool? The idea with adding the shadow object to the request was just > > to get it back in the pool and purgeable asap. I also thought it would limit > > some additional code given that we know buffers in the pool have had any > > pending work completed. Maybe the suggested approach would do a better job > > of those things though. > > I was thinking that a pool is basically a list of bo, and you simply > query whether the oldest was still busy when we need a new bo. Which is > the same as how userspace implements its pool of active/inactive objects. Yeah, linking the ggtt vma of the shadow batch into the eb list should be the most natural solution. We need the same trickery for secure batches to make sure they're bound into the ggtt with full ppgtt anyway. Yeah, that's one of the tasks I'm signed up on and slacked off about :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch