From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 43/53] drm/i915/bdw: Make sure error capture
 keeps working with Execlists
Date: Wed, 18 Jun 2014 22:53:32 +0200
Message-ID: <20140618205332.GG5821@phenom.ffwll.local>
References: <1402673891-14618-1-git-send-email-oscar.mateo@intel.com>
 <1402673891-14618-44-git-send-email-oscar.mateo@intel.com>
 <20140618205208.GF5821@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169])
 by gabe.freedesktop.org (Postfix) with ESMTP id CE7B16E0E1
 for <intel-gfx@lists.freedesktop.org>; Wed, 18 Jun 2014 13:53:39 -0700 (PDT)
Received: by mail-wi0-f169.google.com with SMTP id hi2so9154943wib.0
 for <intel-gfx@lists.freedesktop.org>; Wed, 18 Jun 2014 13:53:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140618205208.GF5821@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: oscar.mateo@intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jun 18, 2014 at 10:52:08PM +0200, Daniel Vetter wrote:
> On Fri, Jun 13, 2014 at 04:38:01PM +0100, oscar.mateo@intel.com wrote:
> > From: Oscar Mateo <oscar.mateo@intel.com>
> > 
> > Since the ringbuffer does not belong per engine anymore, we have to
> > make sure that we are always recording the correct ringbuffer.
> > 
> > TODO: This is only a small fix to keep basic error capture working, but
> > we need to add more information for it to be useful (e.g. dump the
> > context being executed).
> 
> I think we should dump the two lrc submitted to the hw port (our decoder
> can deal with arbitrary amounts of rings, just name them foo1 and foo2)
> and the overall execlist submission queue with a few hints what's going on
> should be a useful start. The scheduler patches can then pimp this further
> I guess.

ofc this can be done later on, but needs to be tracked somewhere.
Historically we suck badly at delivering such follow-up work.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch