From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Track frontbuffer
 invalidation/flushing
Date: Thu, 19 Jun 2014 18:15:50 +0200
Message-ID: <20140619161550.GY5821@phenom.ffwll.local>
References: <1403181687-26717-1-git-send-email-daniel.vetter@ffwll.ch>
 <1403186519-23368-1-git-send-email-daniel.vetter@ffwll.ch>
 <20140619151208.GA8476@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by gabe.freedesktop.org (Postfix) with ESMTP id 26EF66E8EC
 for <intel-gfx@lists.freedesktop.org>; Thu, 19 Jun 2014 09:15:59 -0700 (PDT)
Received: by mail-wg0-f46.google.com with SMTP id y10so2542359wgg.29
 for <intel-gfx@lists.freedesktop.org>; Thu, 19 Jun 2014 09:15:58 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140619151208.GA8476@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jun 19, 2014 at 04:12:08PM +0100, Chris Wilson wrote:
> On Thu, Jun 19, 2014 at 04:01:59PM +0200, Daniel Vetter wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
> > index 99b6c142a095..1c002196ed47 100644
> > --- a/drivers/gpu/drm/i915/intel_overlay.c
> > +++ b/drivers/gpu/drm/i915/intel_overlay.c
> > @@ -787,6 +787,9 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
> >  	overlay->old_vid_bo = overlay->vid_bo;
> >  	overlay->vid_bo = new_bo;
> >  
> > +	intel_frontbuffer_flush(dev,
> > +				INTEL_FRONTBUFFER_OVERLAY(pipe));
> > +
> 
> If we want to be strict, we could do the flip_prepare, flip_complete
> here as well. Basically, I'm arguing that this is actually a
> semi-disguised flip.

Fixed.

> With this changed to _flip,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, I've merged the core patches + the psr patches that Rodrigo
already reviewed to dinq. The remaining parts are in my psr-stuff branch
so that Rodrigo finish the byt rebasing on top of it while I'm
vacationing.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch