From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 08/11] drm/i915: Kill duplicated cdclk
 readout code from i2c
Date: Wed, 25 Jun 2014 11:58:21 -0700
Message-ID: <20140625115821.7a2fa380@jbarnes-desktop>
References: <1402655877-6460-1-git-send-email-ville.syrjala@linux.intel.com>
 <1402655877-6460-9-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com
 [209.85.192.182])
 by gabe.freedesktop.org (Postfix) with ESMTP id 288CA6E25B
 for <intel-gfx@lists.freedesktop.org>; Wed, 25 Jun 2014 11:57:48 -0700 (PDT)
Received: by mail-pd0-f182.google.com with SMTP id y13so2002970pdi.27
 for <intel-gfx@lists.freedesktop.org>; Wed, 25 Jun 2014 11:57:48 -0700 (PDT)
In-Reply-To: <1402655877-6460-9-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAxMyBKdW4gMjAxNCAxMzozNzo1NCArMDMwMAp2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu
dGVsLmNvbSB3cm90ZToKCj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp
bnV4LmludGVsLmNvbT4KPiAKPiBXZSBoYXZlIGEgc2xpZ2h0bHkgZGlmZmVyZW50IHdheSBvZiBy
ZWFkb2luZyBvdXQgdGhlIGNkY2xrIGluCj4gZ21idXNfc2V0X2ZyZXEoKS4gS2lsbCB0aGF0IGFu
ZCBqdXN0IGNhbGwgLmdldF9kaXNwbGF5X2Nsb2NrX3NwZWVkKCkuCj4gCj4gQWxzbyBuZWVkIHRv
IHJlbW92ZSB0aGUgR01CVVNGUkVRIHVwZGF0ZSBmcm9tIGludGVsX2kyY19yZXNldCgpIHNpbmNl
Cj4gdGhhdCBnZXRzIGNhbGxlZCB3YXkgdG9vIGVhcmx5LiBMZXQncyBkbyBpdCBpbiBpbnRlbF9t
b2Rlc2V0X2luaXRfaHcoKQo+IGluc3RlYWQsIGFuZCBhbHNvIHB1bGwgdGhlIGluaXRpYWwgdmx2
X2NkY2xrX2ZyZXEgdXBkYXRlIHRoZXJlIGZyb20KPiBpbml0X2Nsb2NrIGdhdGluZy4KPiAKPiBT
aWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyNSAr
KysrKysrKysrKysrKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAg
fCAgMSAtCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5jICAgICB8IDU0IC0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9wbS5jICAgICAgfCAgNCAtLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25z
KCspLCA2MyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j
Cj4gaW5kZXggNjAxZTk3ZS4uMzNjYzIxMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
aXNwbGF5LmMKPiBAQCAtNDQzMCw3ICs0NDMwLDcgQEAgc3RhdGljIHZvaWQgbW9kZXNldF91cGRh
dGVfY3J0Y19wb3dlcl9kb21haW5zKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIH0KPiAgCj4g
IC8qIHJldHVybnMgSFBMTCBmcmVxdWVuY3kgaW4ga0h6ICovCj4gLWludCB2YWxsZXl2aWV3X2dl
dF92Y28oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgaW50IHZh
bGxleXZpZXdfZ2V0X3ZjbyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsK
PiAgCWludCBocGxsX2ZyZXEsIHZjb19mcmVxW10gPSB7IDgwMCwgMTYwMCwgMjAwMCwgMjQwMCB9
Owo+ICAKPiBAQCAtNDQ0Myw2ICs0NDQzLDIyIEBAIGludCB2YWxsZXl2aWV3X2dldF92Y28oc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJcmV0dXJuIHZjb19mcmVxW2hwbGxf
ZnJlcV0gKiAxMDAwOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCB2bHZfdXBkYXRlX2NkY2xrKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwo+ICsJZGV2X3ByaXYtPnZsdl9jZGNsa19m
cmVxID0gZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Rpc3BsYXlfY2xvY2tfc3BlZWQoZGV2KTsKPiAr
CURSTV9ERUJVR19EUklWRVIoIkN1cnJlbnQgQ0QgY2xvY2sgcmF0ZTogJWQga0h6IiwKPiArCQkJ
IGRldl9wcml2LT52bHZfY2RjbGtfZnJlcSk7Cj4gKwo+ICsJLyoKPiArCSAqIFByb2dyYW0gdGhl
IGdtYnVzX2ZyZXEgYmFzZWQgb24gdGhlIGNkY2xrIGZyZXF1ZW5jeS4KPiArCSAqIEJTcGVjIGVy
cm9uZW91c2x5IGNsYWltcyB3ZSBzaG91bGQgYWltIGZvciA0TUh6LCBidXQKPiArCSAqIGluIGZh
Y3QgMU1IeiBpcyB0aGUgY29ycmVjdCBmcmVxdWVuY3kuCj4gKwkgKi8KPiArCUk5MTVfV1JJVEUo
R01CVVNGUkVRX1ZMViwgZGV2X3ByaXYtPnZsdl9jZGNsa19mcmVxKTsKPiArfQo+ICsKPiAgLyog
QWRqdXN0IENEY2xrIGRpdmlkZXJzIHRvIGFsbG93IGhpZ2ggcmVzIG9yIHNhdmUgcG93ZXIgaWYg
cG9zc2libGUgKi8KPiAgc3RhdGljIHZvaWQgdmFsbGV5dmlld19zZXRfY2RjbGsoc3RydWN0IGRy
bV9kZXZpY2UgKmRldiwgaW50IGNkY2xrKQo+ICB7Cj4gQEAgLTQ0NTAsNyArNDQ2Niw2IEBAIHN0
YXRpYyB2b2lkIHZhbGxleXZpZXdfc2V0X2NkY2xrKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGlu
dCBjZGNsaykKPiAgCXUzMiB2YWwsIGNtZDsKPiAgCj4gIAlXQVJOX09OKGRldl9wcml2LT5kaXNw
bGF5LmdldF9kaXNwbGF5X2Nsb2NrX3NwZWVkKGRldikgIT0gZGV2X3ByaXYtPnZsdl9jZGNsa19m
cmVxKTsKPiAtCWRldl9wcml2LT52bHZfY2RjbGtfZnJlcSA9IGNkY2xrOwo+ICAKPiAgCWlmIChj
ZGNsayA+PSAzMjAwMDApIC8qIGp1bXAgdG8gaGlnaGVzdCB2b2x0YWdlIGZvciA0MDBNSHogdG9v
ICovCj4gIAkJY21kID0gMjsKPiBAQCAtNDUwNyw4ICs0NTIyLDcgQEAgc3RhdGljIHZvaWQgdmFs
bGV5dmlld19zZXRfY2RjbGsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGNkY2xrKQo+ICAJ
dmx2X2J1bml0X3dyaXRlKGRldl9wcml2LCBCVU5JVF9SRUdfQklTT0MsIHZhbCk7Cj4gIAltdXRl
eF91bmxvY2soJmRldl9wcml2LT5kcGlvX2xvY2spOwo+ICAKPiAtCS8qIFNpbmNlIHdlIGNoYW5n
ZWQgdGhlIENEY2xrLCB3ZSBuZWVkIHRvIHVwZGF0ZSB0aGUgR01CVVNGUkVRIHRvbyAqLwo+IC0J
aW50ZWxfaTJjX3Jlc2V0KGRldik7Cj4gKwl2bHZfdXBkYXRlX2NkY2xrKGRldik7Cj4gIH0KPiAg
Cj4gIHN0YXRpYyBpbnQgdmFsbGV5dmlld19jYWxjX2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiwKPiBAQCAtMTE5NzQsNiArMTE5ODgsOSBAQCB2b2lkIGludGVsX21vZGVz
ZXRfaW5pdF9odyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlpbnRlbF9wcmVwYXJl
X2RkaShkZXYpOwo+ICAKPiArCWlmIChJU19WQUxMRVlWSUVXKGRldikpCj4gKwkJdmx2X3VwZGF0
ZV9jZGNsayhkZXYpOwo+ICsKPiAgCWludGVsX2luaXRfY2xvY2tfZ2F0aW5nKGRldik7Cj4gIAo+
ICAJaW50ZWxfcmVzZXRfZHBpbyhkZXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5k
ZXggNjVjZTBiYi4uNTc0MGJlMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAg
LTgwMCw3ICs4MDAsNiBAQCB2b2lkIGhzd19kaXNhYmxlX2lwcyhzdHJ1Y3QgaW50ZWxfY3J0YyAq
Y3J0Yyk7Cj4gIHZvaWQgaW50ZWxfZGlzcGxheV9zZXRfaW5pdF9wb3dlcihzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2LCBib29sIGVuYWJsZSk7Cj4gIGVudW0gaW50ZWxfZGlzcGxheV9wb3dl
cl9kb21haW4KPiAgaW50ZWxfZGlzcGxheV9wb3J0X3Bvd2VyX2RvbWFpbihzdHJ1Y3QgaW50ZWxf
ZW5jb2RlciAqaW50ZWxfZW5jb2Rlcik7Cj4gLWludCB2YWxsZXl2aWV3X2dldF92Y28oc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgdm9pZCBpbnRlbF9tb2RlX2Zyb21fcGlw
ZV9jb25maWcoc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUsCj4gIAkJCQkgc3RydWN0IGlu
dGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZyk7Cj4gIGludCBpbnRlbF9mb3JtYXRfdG9fZm91
cmNjKGludCBmb3JtYXQpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9pMmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5jCj4gaW5kZXggOWNlNGYw
OS4uYjMxMDg4YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9pMmMu
Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5jCj4gQEAgLTM0LDExICsz
NCw2IEBACj4gICNpbmNsdWRlIDxkcm0vaTkxNV9kcm0uaD4KPiAgI2luY2x1ZGUgImk5MTVfZHJ2
LmgiCj4gIAo+IC1lbnVtIGRpc3BfY2xrIHsKPiAtCUNEQ0xLLAo+IC0JQ1pDTEsKPiAtfTsKPiAt
Cj4gIHN0cnVjdCBnbWJ1c19wb3J0IHsKPiAgCWNvbnN0IGNoYXIgKm5hbWU7Cj4gIAlpbnQgcmVn
Owo+IEBAIC02Myw2MCArNTgsMTEgQEAgdG9faW50ZWxfZ21idXMoc3RydWN0IGkyY19hZGFwdGVy
ICppMmMpCj4gIAlyZXR1cm4gY29udGFpbmVyX29mKGkyYywgc3RydWN0IGludGVsX2dtYnVzLCBh
ZGFwdGVyKTsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBnZXRfZGlzcF9jbGtfZGl2KHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJICAgIGVudW0gZGlzcF9jbGsgY2xrKQo+
IC17Cj4gLQl1MzIgcmVnX3ZhbDsKPiAtCWludCBjbGtfcmF0aW87Cj4gLQo+IC0JcmVnX3ZhbCA9
IEk5MTVfUkVBRChDWkNMS19DRENMS19GUkVRX1JBVElPKTsKPiAtCj4gLQlpZiAoY2xrID09IENE
Q0xLKQo+IC0JCWNsa19yYXRpbyA9Cj4gLQkJCSgocmVnX3ZhbCAmIENEQ0xLX0ZSRVFfTUFTSykg
Pj4gQ0RDTEtfRlJFUV9TSElGVCkgKyAxOwo+IC0JZWxzZQo+IC0JCWNsa19yYXRpbyA9IChyZWdf
dmFsICYgQ1pDTEtfRlJFUV9NQVNLKSArIDE7Cj4gLQo+IC0JcmV0dXJuIGNsa19yYXRpbzsKPiAt
fQo+IC0KPiAtc3RhdGljIHZvaWQgZ21idXNfc2V0X2ZyZXEoc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2KQo+IC17Cj4gLQlpbnQgdmNvLCBnbWJ1c19mcmVxID0gMCwgY2RjbGtfZGl2
Owo+IC0KPiAtCUJVR19PTighSVNfVkFMTEVZVklFVyhkZXZfcHJpdi0+ZGV2KSk7Cj4gLQo+IC0J
dmNvID0gdmFsbGV5dmlld19nZXRfdmNvKGRldl9wcml2KSAvIDEwMDA7Cj4gLQo+IC0JLyogR2V0
IHRoZSBDRENMSyBkaXZpZGUgcmF0aW8gKi8KPiAtCWNkY2xrX2RpdiA9IGdldF9kaXNwX2Nsa19k
aXYoZGV2X3ByaXYsIENEQ0xLKTsKPiAtCj4gLQkvKgo+IC0JICogUHJvZ3JhbSB0aGUgZ21idXNf
ZnJlcSBiYXNlZCBvbiB0aGUgY2RjbGsgZnJlcXVlbmN5Lgo+IC0JICogQlNwZWMgZXJyb25lb3Vz
bHkgY2xhaW1zIHdlIHNob3VsZCBhaW0gZm9yIDRNSHosIGJ1dAo+IC0JICogaW4gZmFjdCAxTUh6
IGlzIHRoZSBjb3JyZWN0IGZyZXF1ZW5jeS4KPiAtCSAqLwo+IC0JaWYgKGNkY2xrX2RpdikKPiAt
CQlnbWJ1c19mcmVxID0gKHZjbyA8PCAxKSAvIGNkY2xrX2RpdjsKPiAtCj4gLQlpZiAoV0FSTl9P
TihnbWJ1c19mcmVxID09IDApKQo+IC0JCXJldHVybjsKPiAtCj4gLQlJOTE1X1dSSVRFKEdNQlVT
RlJFUV9WTFYsIGdtYnVzX2ZyZXEpOwo+IC19Cj4gLQo+ICB2b2lkCj4gIGludGVsX2kyY19yZXNl
dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAKPiAtCS8qCj4gLQkgKiBJbiBCSU9T
LWxlc3Mgc3lzdGVtLCBwcm9ncmFtIHRoZSBjb3JyZWN0IGdtYnVzIGZyZXF1ZW5jeQo+IC0JICog
YmVmb3JlIHJlYWRpbmcgZWRpZC4KPiAtCSAqLwo+IC0JaWYgKElTX1ZBTExFWVZJRVcoZGV2KSkK
PiAtCQlnbWJ1c19zZXRfZnJlcShkZXZfcHJpdik7Cj4gLQo+ICAJSTkxNV9XUklURShkZXZfcHJp
di0+Z3Bpb19tbWlvX2Jhc2UgKyBHTUJVUzAsIDApOwo+ICAJSTkxNV9XUklURShkZXZfcHJpdi0+
Z3Bpb19tbWlvX2Jhc2UgKyBHTUJVUzQsIDApOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5j
Cj4gaW5kZXggNjdmMDE5YzEuLjlkN2IwODIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK
PiBAQCAtNTUzNSwxMCArNTUzNSw2IEBAIHN0YXRpYyB2b2lkIHZhbGxleXZpZXdfaW5pdF9jbG9j
a19nYXRpbmcoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCX0KPiAgCURSTV9ERUJVR19EUklW
RVIoIkREUiBzcGVlZDogJWQgTUh6IiwgZGV2X3ByaXYtPm1lbV9mcmVxKTsKPiAgCj4gLQlkZXZf
cHJpdi0+dmx2X2NkY2xrX2ZyZXEgPSBkZXZfcHJpdi0+ZGlzcGxheS5nZXRfZGlzcGxheV9jbG9j
a19zcGVlZChkZXYpOwo+IC0JRFJNX0RFQlVHX0RSSVZFUigiQ3VycmVudCBDRCBjbG9jayByYXRl
OiAlZCBrSHoiLAo+IC0JCQkgZGV2X3ByaXYtPnZsdl9jZGNsa19mcmVxKTsKPiAtCj4gIAlJOTE1
X1dSSVRFKERTUENMS19HQVRFX0QsIFZSSFVOSVRfQ0xPQ0tfR0FURV9ESVNBQkxFKTsKPiAgCj4g
IAkvKiBXYURpc2FibGVFYXJseUN1bGw6dmx2ICovCgpOaWNlIGRpZmZzdGF0LgoKUmV2aWV3ZWQt
Ynk6IEplc3NlIEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgoKLS0gCkplc3NlIEJh
cm5lcywgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ
bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK