Re: [RFC 08/44] drm/i915: Added GPU scheduler config option

Daniel Vetter
2014-07-07T18:58:11Z

On Thu, Jun 26, 2014 at 06:23:59PM +0100, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Added a Kconfig option for enabling/disabling the GPU scheduler.
> ---
> drivers/gpu/drm/i915/Kconfig | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 437e182..22a036b 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -81,3 +81,11 @@ config DRM_I915_UMS
> enable this only if you have ancient versions of the DDX drivers.
>
> If in doubt, say "N".
> +
> +config DRM_I915_SCHEDULER
> + bool "Enable GPU scheduler on Intel hardware"
> + depends on DRM_I915
> + default y
> + help
> + Choose this option to enable GPU task scheduling for improved
> + performance and efficiency.

NACK. We ship one driver in one well tested config, everything else is a
nightmare. There's very few exceptions (currently MMU_NOTIFIER and
optional FBDEV support which have some really good reasons attached to
them). And I'm still grumpy about the MMU_NOTIFIER one ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch