From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [RFC 11/44] drm/i915: Added scheduler hook into
 i915_seqno_passed()
Date: Wed, 2 Jul 2014 11:14:35 -0700
Message-ID: <20140702111435.75e2c842@jbarnes-desktop>
References: <1403803475-16337-1-git-send-email-John.C.Harrison@Intel.com>
 <1403803475-16337-12-git-send-email-John.C.Harrison@Intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
 [209.85.220.53])
 by gabe.freedesktop.org (Postfix) with ESMTP id A65146E5D3
 for <Intel-GFX@lists.freedesktop.org>; Wed,  2 Jul 2014 11:13:51 -0700 (PDT)
Received: by mail-pa0-f53.google.com with SMTP id ey11so12813523pad.26
 for <Intel-GFX@lists.freedesktop.org>; Wed, 02 Jul 2014 11:13:51 -0700 (PDT)
In-Reply-To: <1403803475-16337-12-git-send-email-John.C.Harrison@Intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: John.C.Harrison@Intel.com
Cc: Intel-GFX@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 26 Jun 2014 18:24:02 +0100
John.C.Harrison@Intel.com wrote:

> +bool i915_scheduler_is_seqno_in_flight(struct intel_engine_cs *ring,
> +				uint32_t seqno, bool *completed);
> +

In what cases might the return value not match the completed value?  I
guess I'll see in a later patch...

Same comment about the ifdef applies here; looks like you have some
runtime checking in place too, which seems sufficient to me.

-- 
Jesse Barnes, Intel Open Source Technology Center