From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] igt/gem_partial_pwrite_pread: Add set-cache
 subtest to validate JIRA VIZ-3721
Date: Mon, 7 Jul 2014 11:07:59 +0200
Message-ID: <20140707090759.GL5821@phenom.ffwll.local>
References: <1402607917-12847-1-git-send-email-armin.c.reese@intel.com>
 <07EEC142D30DAC40BA4DD9C0F9EE5109405B7767@FMSMSX107.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
 by gabe.freedesktop.org (Postfix) with ESMTP id 874D66E2A3
 for <intel-gfx@lists.freedesktop.org>; Mon,  7 Jul 2014 02:07:49 -0700 (PDT)
Received: by mail-wg0-f44.google.com with SMTP id k14so3982100wgh.3
 for <intel-gfx@lists.freedesktop.org>; Mon, 07 Jul 2014 02:07:48 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <07EEC142D30DAC40BA4DD9C0F9EE5109405B7767@FMSMSX107.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Reese, Armin C" <armin.c.reese@intel.com>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Barnes,
 Jesse" <jesse.barnes@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jul 02, 2014 at 04:36:51PM +0000, Reese, Armin C wrote:
> Hi Daniel,
> 
> Is it possible to get this patch on the review board?  I've been on
> vacation a couple of weeks and haven't been around to push it.

Already done the review in my other reply ... Have you missed it?

http://www.spinics.net/lists/intel-gfx/msg47146.html

-Daniel

> 
> Thanks,
> Armin
> 
> -----Original Message-----
> From: Reese, Armin C 
> Sent: Thursday, June 12, 2014 2:19 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Reese, Armin C
> Subject: [PATCH] igt/gem_partial_pwrite_pread: Add set-cache subtest to validate JIRA VIZ-3721
> 
> From: Armin Reese <armin.c.reese@intel.com>
> 
> This subtest forces the driver down the code path in i915_gem_object_set_cache_level() which unbinds VMAs and triggers the kernel panic described in VIZ-3721.  This test will pass if the bug fix is in place.
> 
> Bugzilla:  https://bugs.fredesktop.org/show_bug.cgi?id=76384
> Signed-off-by:  Armin Reese <armin.c.reese@intel.com>
> ---
>  tests/gem_partial_pwrite_pread.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tests/gem_partial_pwrite_pread.c b/tests/gem_partial_pwrite_pread.c
> index 7945ba7..3e3ecc9 100644
> --- a/tests/gem_partial_pwrite_pread.c
> +++ b/tests/gem_partial_pwrite_pread.c
> @@ -131,6 +131,14 @@ static void test_partial_reads(void)
>  
>  }
>  
> +static void test_set_cache(void)
> +{
> +	igt_info("checking set-cache\n");
> +
> +	blt_bo_fill(staging_bo, scratch_bo, 0);
> +
> +}
> +
>  static void test_partial_writes(void)
>  {
>  	int i, j;
> @@ -244,6 +252,9 @@ static void do_tests(int cache_level, const char *suffix)
>  			gem_set_caching(fd, scratch_bo->handle, cache_level);
>  	}
>  
> +	igt_subtest_f("set-cache%s", suffix)
> +		test_set_cache();
> +
>  	igt_subtest_f("reads%s", suffix)
>  		test_partial_reads();
>  
> --
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch