From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 3/3] drm/i915: gmch: fix stuck primary plane due to memory self-refresh mode Date: Mon, 7 Jul 2014 11:36:29 +0200 Message-ID: <20140707093629.GP5821@phenom.ffwll.local> References: <1402660461-32294-1-git-send-email-imre.deak@intel.com> <1402660461-32294-3-git-send-email-imre.deak@intel.com> <21420.39347.780019.322745@linux-qknr.fritz.box> <20140627062235.GC5029@nuc-i3427.alporthouse.com> <21421.30691.26763.558750@linux-qknr.fritz.box> <1403894332.11805.17.camel@intelbox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 531376E2A4 for ; Mon, 7 Jul 2014 02:36:19 -0700 (PDT) Received: by mail-we0-f179.google.com with SMTP id w62so4069397wes.24 for ; Mon, 07 Jul 2014 02:36:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1403894332.11805.17.camel@intelbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Fri, Jun 27, 2014 at 09:38:52PM +0300, Imre Deak wrote: > Hi Egbert, > > On Fri, 2014-06-27 at 15:55 +0200, Egbert Eich wrote: > > Chris Wilson writes: > > > On Fri, Jun 27, 2014 at 12:07:47AM +0200, Egbert Eich wrote: > > > > > > > > Hi Daniel, hi Imre, > > > > > > > > Daniel Vetter writes: > > > > > Adding Egbert since he's done the original hack here. Imre please keep > > > > > him on cc. > > > > > -Daniel > > > > > > > > I finally managed to get this set of patches tested on the platform that > > > > exhibited the intermittent blanking problem when terminating the Xserver. > > > > > > > > I can confirm that Imre's patches resolve the issue and that g4x_fixup_plane() > > > > which I had introduced after extensive experiments is no longer needed to > > > > prevent the blanking from happening. > > > > If you want I can provide a patch to back this out with the appropriate > > > > comments once Imre's patches are in. > > > > > > That would be ideal. > > > > Is there a chance that Imre's patches will go into the > > Intel repo any time soon? Then I could use the commit Id in > > the patch description. > > Yes, Deepak promised to review it early next week, so it could be > applied after that. I guess we could add your Tested-by too. Back from my vacation and patches are merged. Egbert, please submit your patch so that I can merge it. Thanks for patches, review&testing. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch