From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/8] drm/i915: Extract context backing object allocation Date: Tue, 8 Jul 2014 12:31:32 +0200 Message-ID: <20140708103132.GX17271@phenom.ffwll.local> References: <1404401285-19918-1-git-send-email-oscar.mateo@intel.com> <20140708093926.GJ26405@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D5686E521 for ; Tue, 8 Jul 2014 03:31:22 -0700 (PDT) Received: by mail-wg0-f49.google.com with SMTP id a1so2314284wgh.8 for ; Tue, 08 Jul 2014 03:31:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140708093926.GJ26405@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , oscar.mateo@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 08, 2014 at 10:39:26AM +0100, Chris Wilson wrote: > On Thu, Jul 03, 2014 at 04:27:58PM +0100, oscar.mateo@intel.com wrote: > > From: Oscar Mateo > > > > This is preparatory work for Execlists: we plan to use it later to > > allocate our own context objects (since Logical Ring Contexts do > > not have the same kind of backing objects). > > > > No functional changes. > > > > Reviewed-by: Jesse Barnes > > Signed-off-by: Oscar Mateo > > The series looks fine. My gripe is that the split between context and > ring is messy (I think that a context is now a view of the entire > hardware state and so our bookkeeping should reflect that) and leads to > some subtle bugs where the bookkeeping on the ring is not transferred > correctly to the context. However, this series is a good starting point > to fix the more esoteric problems. > > Reviewed-by: Chris Wilson Thanks for patches & review, all merged to dinq. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch