From: Damien Lespiau <damien.lespiau@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests
Date: Wed, 9 Jul 2014 17:42:47 +0100 [thread overview]
Message-ID: <20140709164247.GF341@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20140709142350.GX17271@phenom.ffwll.local>
On Wed, Jul 09, 2014 at 04:23:50PM +0200, Daniel Vetter wrote:
> For me the only trouble with this disdinction is that people consistently
> place tests in the wrong Makefile target. Hence I'd like to see those two
> Makefile targets being unified (which requires adjustements in piglit,
> too) to validate this work. Iirc Thomas is also working on this.
In all generalities, I think it makes things a lot simpler if we only
one case to care about. In this instance:
"A test is a set of one or more subtests"
Seems a good invariant to me. Not sure I understand what the objections
are.
--
Damien
prev parent reply other threads:[~2014-07-09 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 14:15 [PATCH 0/2] Single tests to respond to --list-subtests tim.gore
2014-06-27 14:15 ` [PATCH 1/2] intel-gpu-tools: pass argc/argv to simple main tim.gore
2014-07-01 9:19 ` Thomas Wood
2014-07-07 16:12 ` Daniel Vetter
2014-07-09 13:50 ` Gore, Tim
2014-07-09 14:20 ` Daniel Vetter
2014-06-27 14:15 ` [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests tim.gore
2014-07-01 9:26 ` Thomas Wood
2014-07-07 16:09 ` Daniel Vetter
2014-07-09 13:23 ` Gore, Tim
2014-07-09 14:23 ` Daniel Vetter
2014-07-09 16:42 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709164247.GF341@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox