From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests Date: Wed, 9 Jul 2014 17:42:47 +0100 Message-ID: <20140709164247.GF341@strange.amr.corp.intel.com> References: <1403878537-29020-1-git-send-email-tim.gore@intel.com> <1403878537-29020-3-git-send-email-tim.gore@intel.com> <20140707160937.GL5821@phenom.ffwll.local> <8FCC70911F3E9548866CA0E51893BCC31A1CDD53@IRSMSX105.ger.corp.intel.com> <20140709142350.GX17271@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F1066E322 for ; Wed, 9 Jul 2014 09:43:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140709142350.GX17271@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 09, 2014 at 04:23:50PM +0200, Daniel Vetter wrote: > For me the only trouble with this disdinction is that people consistently > place tests in the wrong Makefile target. Hence I'd like to see those two > Makefile targets being unified (which requires adjustements in piglit, > too) to validate this work. Iirc Thomas is also working on this. In all generalities, I think it makes things a lot simpler if we only one case to care about. In this instance: "A test is a set of one or more subtests" Seems a good invariant to me. Not sure I understand what the objections are. -- Damien