From: Damien Lespiau <damien.lespiau@intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 3/4] drm/i915: check the power domains in intel_lvds_get_hw_state()
Date: Thu, 10 Jul 2014 15:19:22 +0100 [thread overview]
Message-ID: <20140710141922.GG3191@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1404491916-5030-4-git-send-email-przanoni@gmail.com>
On Fri, Jul 04, 2014 at 01:38:35PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Just like we do for the other encoders. This should fix some WARNs
> when running pm_rpm on SNB.
>
> Testcase: igt/pm_rpm
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80463
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_lvds.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 4d29a83..8aa7973 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -71,8 +71,13 @@ static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
> struct drm_device *dev = encoder->base.dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
> + enum intel_display_power_domain power_domain;
> u32 tmp;
>
> + power_domain = intel_display_port_power_domain(encoder);
> + if (!intel_display_power_enabled(dev_priv, power_domain))
> + return false;
> +
> tmp = I915_READ(lvds_encoder->reg);
>
> if (!(tmp & LVDS_PORT_EN))
> --
> 2.0.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-07-10 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 16:38 [PATCH 0/4] SNB runtime PM fixes Paulo Zanoni
2014-07-04 16:38 ` [PATCH 1/4] drm/i915: add POWER_DOMAIN_PLLS Paulo Zanoni
2014-07-10 14:17 ` Damien Lespiau
2014-07-04 16:38 ` [PATCH 2/4] drm/i915: check the power domains in ironlake_get_pipe_config() Paulo Zanoni
2014-07-10 14:18 ` Damien Lespiau
2014-07-04 16:38 ` [PATCH 3/4] drm/i915: check the power domains in intel_lvds_get_hw_state() Paulo Zanoni
2014-07-10 14:19 ` Damien Lespiau [this message]
2014-07-04 16:38 ` [PATCH 4/4] drm/i915: don't read LVDS regs at compute_config time Paulo Zanoni
2014-07-10 16:33 ` Damien Lespiau
2014-07-10 20:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710141922.GG3191@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox