From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Don't cast a pointer to void* unnecessarily Date: Thu, 10 Jul 2014 22:26:06 +0200 Message-ID: <20140710202606.GL17271@phenom.ffwll.local> References: <1405000363-15950-1-git-send-email-damien.lespiau@intel.com> <1405000363-15950-2-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id C00B96E1AC for ; Thu, 10 Jul 2014 13:25:59 -0700 (PDT) Received: by mail-wi0-f177.google.com with SMTP id ho1so300538wib.10 for ; Thu, 10 Jul 2014 13:25:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 10, 2014 at 04:26:53PM -0300, Paulo Zanoni wrote: > 2014-07-10 10:52 GMT-03:00 Damien Lespiau : > > C is super happy to asign anything pointer to void *. Don't pretend > > otherwise. > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel > > > > > Signed-off-by: Damien Lespiau > > --- > > drivers/gpu/drm/i915/i915_dma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > > index ce69185..2c0bad6 100644 > > --- a/drivers/gpu/drm/i915/i915_dma.c > > +++ b/drivers/gpu/drm/i915/i915_dma.c > > @@ -1596,7 +1596,7 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) > > if (dev_priv == NULL) > > return -ENOMEM; > > > > - dev->dev_private = (void *)dev_priv; > > + dev->dev_private = dev_priv; > > dev_priv->dev = dev; > > > > /* copy initial configuration to dev_priv->info */ > > -- > > 1.8.3.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Paulo Zanoni > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch