From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH i-g-t 02/43] igt_kms: Make has_universal_planes a bitfield Date: Fri, 11 Jul 2014 15:13:10 +0100 Message-ID: <20140711141310.GC8230@strange.amr.corp.intel.com> References: <1405015244-11370-1-git-send-email-damien.lespiau@intel.com> <1405015244-11370-3-git-send-email-damien.lespiau@intel.com> <20140711063441.GR17271@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 9597F6E842 for ; Fri, 11 Jul 2014 07:13:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140711063441.GR17271@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 11, 2014 at 08:34:41AM +0200, Daniel Vetter wrote: > On Thu, Jul 10, 2014 at 07:00:03PM +0100, Damien Lespiau wrote: > > Signed-off-by: Damien Lespiau > > --- > > lib/igt_kms.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/igt_kms.h b/lib/igt_kms.h > > index a079fc2..058114a 100644 > > --- a/lib/igt_kms.h > > +++ b/lib/igt_kms.h > > @@ -153,7 +153,7 @@ struct igt_display { > > unsigned long pipes_in_use; > > igt_output_t *outputs; > > igt_pipe_t pipes[I915_MAX_PIPES]; > > - bool has_universal_planes; > > + unsigned int has_universal_planes : 1; > > tbh I didn't see the point of this and didn't see any follow-up patch > which would explain the motivation ... Fair, I dropped this one for the series. -- Damien