From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [v3 09/13] drm/i915: Add rotation property for sprites Date: Sat, 12 Jul 2014 00:06:06 +0200 Message-ID: <20140711220606.GK17271@phenom.ffwll.local> References: <1404795723-9630-1-git-send-email-sonika.jindal@intel.com> <1404795723-9630-10-git-send-email-sonika.jindal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1404795723-9630-10-git-send-email-sonika.jindal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: sonika.jindal@intel.com Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 08, 2014 at 10:31:59AM +0530, sonika.jindal@intel.com wrote: > From: Ville Syrj=E4l=E4 > = > Sprite planes support 180 degree rotation. The lower layers are now in > place, so hook in the standard rotation property to expose the feature > to the users. > = > v2: Moving rotation_property to drm_plane > = > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Ville Syrj=E4l=E4 > Signed-off-by: Sonika Jindal > Reviewed-by: Imre Deak Also this r-b tag was for v1 (which was ok), not for v2. If you carry over such a review-by tag and make functional changes not discussed with the reviewer you _must_ at least mark the r-b with a (v1) or if it's a big change, drop the tag completely. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch