From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [v3 09/13] drm/i915: Add rotation property for
 sprites
Date: Sat, 12 Jul 2014 00:10:40 +0200
Message-ID: <20140711221040.GL17271@phenom.ffwll.local>
References: <1404795723-9630-1-git-send-email-sonika.jindal@intel.com>
 <1404795723-9630-10-git-send-email-sonika.jindal@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
 [74.125.82.175])
 by gabe.freedesktop.org (Postfix) with ESMTP id 0034D6E89A
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Jul 2014 15:10:31 -0700 (PDT)
Received: by mail-we0-f175.google.com with SMTP id k48so1658473wev.6
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Jul 2014 15:10:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1404795723-9630-10-git-send-email-sonika.jindal@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jul 08, 2014 at 10:31:59AM +0530, sonika.jindal@intel.com wrote:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Sprite planes support 180 degree rotation. The lower layers are now in
> place, so hook in the standard rotation property to expose the feature
> to the users.
> =

> v2: Moving rotation_property to drm_plane
> =

> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_sprite.c |   40 +++++++++++++++++++++++++++++=
+++++-
>  include/drm/drm_crtc.h              |    1 +

One more: A patch titled with "drm/i915: ..." really shouldn't touch
anything outside of drm/i915 directories and so shouldn't introduce any
changes to core drm code. Such changes always need to be split out into a
separate drm patch. Exceptions (like refactoring function interfaces)
obviously apply.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch