From: Daniel Vetter <daniel@ffwll.ch>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Stefan Nagy <public@stefan-nagy.at>
Subject: Re: [PATCH] drm/i915: Ignore VBT backlight presence check on HP Chromebook 14
Date: Sat, 12 Jul 2014 12:07:44 +0200 [thread overview]
Message-ID: <20140712100744.GR17271@phenom.ffwll.local> (raw)
In-Reply-To: <1405116990-5573-1-git-send-email-lkml14@scotdoyle.com>
On Fri, Jul 11, 2014 at 10:16:30PM +0000, Scot Doyle wrote:
> commit c675949ec58ca50d5a3ae3c757892f1560f6e896
> drm/i915: do not setup backlight if not available according to VBT
>
> caused a regression on the HP Chromebook 14 (with Celeron 2955U CPU),
> which has a misconfigured VBT. Apply quirk to ignore the VBT backlight
> presence check during backlight setup.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79813
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> Tested-by: Stefan Nagy <public@stefan-nagy.at>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Picked up for -fixes, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index fe6f1db..5d70f02 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12440,6 +12440,9 @@ static struct intel_quirk intel_quirks[] = {
>
> /* Toshiba CB35 Chromebook (Celeron 2955U) */
> { 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
> +
> + /* HP Chromebook 14 (Celeron 2955U) */
> + { 0x0a06, 0x103c, 0x21ed, quirk_backlight_present },
> };
>
> static void intel_init_quirks(struct drm_device *dev)
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-07-12 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 22:16 [PATCH] drm/i915: Ignore VBT backlight presence check on HP Chromebook 14 Scot Doyle
2014-07-12 10:07 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712100744.GR17271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lkml14@scotdoyle.com \
--cc=public@stefan-nagy.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox