public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Ignore VBT backlight presence check on HP Chromebook 14
@ 2014-07-11 22:16 Scot Doyle
  2014-07-12 10:07 ` Daniel Vetter
  0 siblings, 1 reply; 2+ messages in thread
From: Scot Doyle @ 2014-07-11 22:16 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, Daniel Vetter, Stefan Nagy

commit c675949ec58ca50d5a3ae3c757892f1560f6e896
    drm/i915: do not setup backlight if not available according to VBT

caused a regression on the HP Chromebook 14 (with Celeron 2955U CPU),
which has a misconfigured VBT. Apply quirk to ignore the VBT backlight
presence check during backlight setup.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79813
Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
Tested-by: Stefan Nagy <public@stefan-nagy.at>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index fe6f1db..5d70f02 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12440,6 +12440,9 @@ static struct intel_quirk intel_quirks[] = {
 
 	/* Toshiba CB35 Chromebook (Celeron 2955U) */
 	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
+
+	/* HP Chromebook 14 (Celeron 2955U) */
+	{ 0x0a06, 0x103c, 0x21ed, quirk_backlight_present },
 };
 
 static void intel_init_quirks(struct drm_device *dev)
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/i915: Ignore VBT backlight presence check on HP Chromebook 14
  2014-07-11 22:16 [PATCH] drm/i915: Ignore VBT backlight presence check on HP Chromebook 14 Scot Doyle
@ 2014-07-12 10:07 ` Daniel Vetter
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2014-07-12 10:07 UTC (permalink / raw)
  To: Scot Doyle; +Cc: Jani Nikula, Daniel Vetter, intel-gfx, Stefan Nagy

On Fri, Jul 11, 2014 at 10:16:30PM +0000, Scot Doyle wrote:
> commit c675949ec58ca50d5a3ae3c757892f1560f6e896
>     drm/i915: do not setup backlight if not available according to VBT
> 
> caused a regression on the HP Chromebook 14 (with Celeron 2955U CPU),
> which has a misconfigured VBT. Apply quirk to ignore the VBT backlight
> presence check during backlight setup.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79813
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> Tested-by: Stefan Nagy <public@stefan-nagy.at>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>

Picked up for -fixes, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index fe6f1db..5d70f02 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12440,6 +12440,9 @@ static struct intel_quirk intel_quirks[] = {
>  
>  	/* Toshiba CB35 Chromebook (Celeron 2955U) */
>  	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
> +
> +	/* HP Chromebook 14 (Celeron 2955U) */
> +	{ 0x0a06, 0x103c, 0x21ed, quirk_backlight_present },
>  };
>  
>  static void intel_init_quirks(struct drm_device *dev)
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-12 10:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11 22:16 [PATCH] drm/i915: Ignore VBT backlight presence check on HP Chromebook 14 Scot Doyle
2014-07-12 10:07 ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox