From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Ignore VBT backlight presence
 check on HP Chromebook 14
Date: Sat, 12 Jul 2014 12:07:44 +0200
Message-ID: <20140712100744.GR17271@phenom.ffwll.local>
References: <1405116990-5573-1-git-send-email-lkml14@scotdoyle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41])
 by gabe.freedesktop.org (Postfix) with ESMTP id 810E06E295
 for <intel-gfx@lists.freedesktop.org>; Sat, 12 Jul 2014 03:07:34 -0700 (PDT)
Received: by mail-wg0-f41.google.com with SMTP id z12so2077407wgg.12
 for <intel-gfx@lists.freedesktop.org>; Sat, 12 Jul 2014 03:07:33 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1405116990-5573-1-git-send-email-lkml14@scotdoyle.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Stefan Nagy <public@stefan-nagy.at>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jul 11, 2014 at 10:16:30PM +0000, Scot Doyle wrote:
> commit c675949ec58ca50d5a3ae3c757892f1560f6e896
>     drm/i915: do not setup backlight if not available according to VBT
> 
> caused a regression on the HP Chromebook 14 (with Celeron 2955U CPU),
> which has a misconfigured VBT. Apply quirk to ignore the VBT backlight
> presence check during backlight setup.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79813
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> Tested-by: Stefan Nagy <public@stefan-nagy.at>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>

Picked up for -fixes, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index fe6f1db..5d70f02 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12440,6 +12440,9 @@ static struct intel_quirk intel_quirks[] = {
>  
>  	/* Toshiba CB35 Chromebook (Celeron 2955U) */
>  	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
> +
> +	/* HP Chromebook 14 (Celeron 2955U) */
> +	{ 0x0a06, 0x103c, 0x21ed, quirk_backlight_present },
>  };
>  
>  static void intel_init_quirks(struct drm_device *dev)
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch