From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v4 1/4] drm/crtc: Add property for aspect ratio Date: Mon, 14 Jul 2014 08:51:46 +0200 Message-ID: <20140714065144.GE2081@ulmo> References: <20140610111557.GA10797@ulmo> <1402463808-31446-1-git-send-email-vandana.kannan@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1469813025==" Return-path: In-Reply-To: <1402463808-31446-1-git-send-email-vandana.kannan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vandana Kannan Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1469813025== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WBsA/oQW3eTA3LlM" Content-Disposition: inline --WBsA/oQW3eTA3LlM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 11, 2014 at 10:46:48AM +0530, Vandana Kannan wrote: > Added a property to enable user space to set aspect ratio. > This patch contains declaration of the property and code to create the > property. >=20 > v2: Thierry's review comments. > - Made aspect ratio enum generic instead of HDMI/CEA specfic > - Removed usage of temporary aspect_ratio variable >=20 > v3: Thierry's review comments. > - Fixed indentation >=20 > v4: Thierry's review comments. > - Return ENOMEM when property creation fails >=20 > Signed-off-by: Vandana Kannan > Cc: Thierry Reding > --- > drivers/gpu/drm/drm_crtc.c | 33 +++++++++++++++++++++++++++++++++ > include/drm/drm_crtc.h | 2 ++ > include/uapi/drm/drm_mode.h | 5 +++++ > 3 files changed, 40 insertions(+) One nit below... > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 37a3e07..a745df3 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -139,6 +139,12 @@ static const struct drm_prop_enum_list drm_scaling_m= ode_enum_list[] =3D > { DRM_MODE_SCALE_ASPECT, "Full aspect" }, > }; > =20 > +static const struct drm_prop_enum_list drm_aspect_ratio_enum_list[] =3D { > + { DRM_MODE_PICTURE_ASPECT_NONE, "Automatic" }, > + { DRM_MODE_PICTURE_ASPECT_4_3, "4:3" }, > + { DRM_MODE_PICTURE_ASPECT_16_9, "16:9" }, > +}; > + > /* > * Non-global properties, but "required" for certain connectors. > */ > @@ -1344,6 +1350,33 @@ int drm_mode_create_scaling_mode_property(struct d= rm_device *dev) > EXPORT_SYMBOL(drm_mode_create_scaling_mode_property); > =20 > /** > + * drm_mode_create_aspect_ratio_property - create aspect ratio property > + * @dev: DRM device > + * > + * Called by a driver the first time it's needed, must be attached to de= sired > + * connectors. > + * > + * Returns: According to Documentation/kernel-doc-nano-HOWTO.txt this section should be named "Return:". But it seems that at least in DRM "Returns:" is used much more often (89:31), so with or without this addressed: Reviewed-by: Thierry Reding --WBsA/oQW3eTA3LlM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTw34AAAoJEN0jrNd/PrOhfEQP/3PGTwMoUE8qKwbpwZe/V5no YgA85a2Lkc7QebqaFIZBcH+h892qkxE/M258Udd7ESpv0CSKbNVO5JPMV6C23wUq tusuRjNDISzVslTw40x1YeaM/OuuGmLRQAj4oq6GLNr9uQlNwUGvjd/tvLXnc+WE BRv5DTCQoK7l/HEohLzdLvQiEz/QuneBWre6r7ul04Yze67TZSe3ziv833fnQZmy EPKmpeEz+SyHHa1G9SrZQYCipjheQzNoRb0ZaYDfDgSiumARaMapRVldxEVAO1au O6+IVoSWT7EzIPfFy5Fr9j4CKu6H4RyHVbglshn1q0OYgB+xr9JVvvIMLtjSqDu1 ocKWAG2ZginxyECIb1XbdPYZgQHo+uOuuVyDObTa6tQevV5HWOj54ak9otoV1S4r /a6dsFwcqB6OAWafw/1J+ewS3W0ArCedooahdf9ATz6fHGuboMl1J8LU3FFk2yXP 5RXvrIRCWOekYN0rW+ylkRfSsG3/8tGEEj+T2KrFrSZdCwkY18/UHOB3OSmbovnq j/121U6eIh4FOILzrZ1suOpYCj2Y3ig6+NEGHhsoNg8uWfpNnMf5Jpyn9WgzIbhr BMz+WGjSJ0I9FhEXPsIRc7Q0cP/gQoxd4v3qxuusFLb0Sqcaj9/0sUw6PnbX+DOV d7ep483wprzHeOSkP1Vw =1voS -----END PGP SIGNATURE----- --WBsA/oQW3eTA3LlM-- --===============1469813025== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1469813025==--