From: Daniel Vetter <daniel@ffwll.ch>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: drm: i915: "plane B assertion failure, should be off on pipe B but is still active"
Date: Mon, 14 Jul 2014 09:18:23 +0200 [thread overview]
Message-ID: <20140714071823.GE15237@phenom.ffwll.local> (raw)
In-Reply-To: <1405322020.19403.0.camel@x220>
On Mon, Jul 14, 2014 at 09:13:40AM +0200, Paul Bolle wrote:
> On Mon, 2014-07-14 at 08:56 +0200, Daniel Vetter wrote:
> > Please test the below patch, thanks.
> > -Daniel
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 82e7d57f0a8a..f0be855ddf45 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -11914,6 +11914,7 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc)
> > * ... */
> > plane = crtc->plane;
> > crtc->plane = !plane;
> > + crtc->primary_enabled = true;
> > dev_priv->display.crtc_disable(&crtc->base);
> > crtc->plane = plane;
> >
>
> Instead of the revert or on top of the revert?
Instead of the revert as an attempt at a proper bugfix. If it doesn't work
my theory about what's going on on your machine is all wrong ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-14 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:05 drm: i915: "plane B assertion failure, should be off on pipe B but is still active" Paul Bolle
2014-07-01 9:17 ` Jani Nikula
2014-07-02 8:53 ` Paul Bolle
2014-07-13 20:32 ` Paul Bolle
2014-07-14 6:56 ` Daniel Vetter
2014-07-14 7:13 ` Paul Bolle
2014-07-14 7:18 ` Daniel Vetter [this message]
2014-07-14 16:47 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714071823.GE15237@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox