Re: [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Tue, 15 Jul 2014 13:03:55 +0530
Deepak S <deepak.s@linux.intel.com> wrote:

> 
> On Saturday 28 June 2014 11:26 AM, deepak.s@linux.intel.com wrote:
> > From: Deepak S <deepak.s@linux.intel.com>
> >
> > Drop WaGsvBringDownFreq on CHV.
> > When in RC6 requesting the min freq should be fine to bring the
> > voltage down.
> >
> > Signed-off-by: Deepak S <deepak.s@linux.intel.com>
> > ---
> >   drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 6b6cfd4..4875f745 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
> >   
> >   	mutex_lock(&dev_priv->rps.hw_lock);
> >   	if (dev_priv->rps.enabled) {
> > -		if (IS_VALLEYVIEW(dev))
> > +		if (IS_CHERRYVIEW(dev))
> > +			valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> > +		else if (IS_VALLEYVIEW(dev))
> >   			vlv_set_rps_idle(dev_priv);
> >   		else
> >   			gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> 
> Hi Jesse,
> 
> can you please review this patch?

Reviewed-by: Jesse Barnes <jbarnes@Virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center