From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 07/10] drm/i915/bdw: collect semaphore error state Date: Mon, 14 Jul 2014 11:04:22 +0100 Message-ID: <20140714100422.GA25136@strange.icx.intel.com> References: <1404147224-2978-1-git-send-email-rodrigo.vivi@intel.com> <1404147224-2978-7-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CC3589FBC for ; Mon, 14 Jul 2014 03:04:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1404147224-2978-7-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Mon, Jun 30, 2014 at 09:53:41AM -0700, Rodrigo Vivi wrote: > + for_each_ring(useless, dev_priv, i) { > + u16 signal_offset = > + (GEN8_SIGNAL_OFFSET(ring, i) & PAGE_MASK) / 4; > + u32 *tmp = error->semaphore_obj->pages[0]; > + > + ering->semaphore_mboxes[i] = tmp[signal_offset]; > + ering->semaphore_seqno[i] = ring->semaphore.sync_seqno[i]; > + } > +} This loops around all the rings, but semaphore_mboxes[] and semaphore_seqno[] are of size (I915_NUM_RINGS - 1). -- Damien