Re: [PATCH 1/2] drm/i915: Provide a config option to select a target platform

[Damien Lespiau <damien.lespiau@intel.com>]

On Mon, Jul 14, 2014 at 11:18:30AM +0100, Barbalho, Rafael wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> > Of Damien Lespiau
> > Sent: Friday, July 11, 2014 6:34 PM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Provide a config option to select a
> > target platform
> > 
> > It'd be nice to be able to target a single platform to reduce the size
> > for the i915 driver.
> > 
> > Start low-fi and coarse grained: it's easy to split the (S)DVO code out,
> > the API surface is reduced to two init functions.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> 
> Is this the right way to go?
> 
> I think what will happen is that we are just going to have everything
> enabled anyway because you'd want your kernel to boot on any intel
> platform. Certainly on the stuff I'm working on I'll just have to
> enable this stuff all the time because I don't know if the system
> image is going to be installed on a broadwell or a valleyview. The
> same comment applies to patch 2.

The patches are already dropped. I guess it depends what you want to do
really. I can see a specific product, say running on Valleyview, that
could turn that on. It sounds likely that people will at least have a
per-platform config file (if not per-platform kernels), which could have
this tweak.

I still think we could save 300+ Kb if taking this to its limits, but
meh.

-- 
Damien